[GitHub] nifi-minifi-cpp issue #430: MINIFICPP-659: Break out CAPI into nanofi

2018-10-30 Thread apiri 
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/430
  
@phrocker it doesn't seem like I was unable to pull them... unfortunately, 
may just have to open up a new PR with that commit


---

[GitHub] nifi-minifi-cpp issue #430: MINIFICPP-659: Break out CAPI into nanofi

2018-10-30 Thread phrocker 
Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/430
  
@apiri rebased but don't see the updates in the PR. Do you see them? 


---

[GitHub] nifi-minifi-cpp issue #430: MINIFICPP-659: Break out CAPI into nanofi

2018-10-30 Thread phrocker 
Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/430
  
@apiri rebasing  now, thanks.


---

[GitHub] nifi-minifi-cpp issue #430: MINIFICPP-659: Break out CAPI into nanofi

2018-10-30 Thread apiri 
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/430
  
@phrocker would you mind rebasing this? didn't want to make any bad 
assumptions between this and current master, otherwise looks good and build was 
fine 


---

[GitHub] nifi-minifi-cpp issue #430: MINIFICPP-659: Break out CAPI into nanofi

2018-10-30 Thread apiri 
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/430
  
reviewing


---