[GitHub] nifi-minifi-cpp pull request #113: MINIFI-337: Update configuration readme f...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/113


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp pull request #113: MINIFI-337: Update configuration readme f...

[apiri]

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/113#discussion_r122976076
  
--- Diff: README.md ---
@@ -302,17 +302,47 @@ Additionally, users can utilize the MiNiFi Toolkit 
Converter (version 0.0.1 - sc
 nifi.security.need.ClientAuth=false
 
 ### Configuring Volatile and NO-OP Repositories
-
+Each of the repositories can be configured to be volatile ( state kept in 
memory and flushed
+ upon restart ) or persistent. Currently, the flow file and provenance 
repositories can persist
+ to LevelDB. The content repository will persist to the local file system 
if a volatile repo
+ is not configured. 
+ 
+ To configure the repositories:
+ 
  in minifi.properties 
  
  # For Volatile Repositories:
- nifi.flow.repository.class.name=VolatileRepository
- nifi.provenance.repository.class.name=VolatileRepository
+ nifi.flowfile.repository.class.name=VolatileFlowFileRepository
--- End diff --

Looks like this is still 
[nifi.provenance.repository.class.name](https://github.com/apache/nifi-minifi-cpp/blob/master/libminifi/src/Configure.cpp#L34).
  Totally fair game to update, but think we should make that change in 
conjunction with this doc update.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp pull request #113: MINIFI-337: Update configuration readme f...

[phrocker]

GitHub user phrocker opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/113

MINIFI-337: Update configuration readme for Repositories

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-337

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #113


commit 450383ae1bf27d4677d92b4e8006142cf79355c2
Author: Marc Parisi 
Date:   2017-06-19T13:33:17Z

MINIFI-337: Update configuration readme for Repositories




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---