[GitHub] nifi-minifi-cpp pull request #190: MINIFI-308 Ensure that all core resources...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/190


---

[GitHub] nifi-minifi-cpp pull request #190: MINIFI-308 Ensure that all core resources...

[achristianson]

Github user achristianson commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/190#discussion_r151761757
  
--- Diff: libminifi/test/script-tests/ExecuteScriptTests.cpp ---
@@ -1,640 +0,0 @@
-/**
--- End diff --

@phrocker Yes, these tests never should have been in there. The file was a 
relic from before Python & Lua were split into separate files.


---

[GitHub] nifi-minifi-cpp pull request #190: MINIFI-308 Ensure that all core resources...

[achristianson]

GitHub user achristianson opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/190

MINIFI-308 Ensure that all core resources are deterministically relea…

…sed at the end of onTrigger calls so that script engines using GC do not 
hold onto them and waste resources

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [x] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/achristianson/nifi-minifi-cpp scriptffrelfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #190


commit c6e7b133590c059dca42256ce19e58ec1fd0
Author: Andrew I. Christianson 
Date:   2017-11-16T00:22:49Z

MINIFI-308 Ensure that all core resources are deterministically released at 
the end of onTrigger calls so that script engines using GC do not hold onto 
them and waste resources




---