[GitHub] nifi-minifi-cpp pull request #405: MINIFICPP-618: Add C2 triggers, first of ...
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/405#discussion_r221072929
--- Diff: libminifi/include/properties/Properties.h ---
@@ -60,6 +60,9 @@ class Properties {
// Get the config value
bool get(std::string key, std::string );
+ // Get the config value
--- End diff --
No apology, please. It's my fault for opening early!. I truly appreciate
the input and hope that when I re-open it you have an opportunity to take a
look!
---
[GitHub] nifi-minifi-cpp pull request #405: MINIFICPP-618: Add C2 triggers, first of ...
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/405#discussion_r221070316
--- Diff: libminifi/include/properties/Properties.h ---
@@ -60,6 +60,9 @@ class Properties {
// Get the config value
bool get(std::string key, std::string );
+ // Get the config value
--- End diff --
sorry
---
[GitHub] nifi-minifi-cpp pull request #405: MINIFICPP-618: Add C2 triggers, first of ...
Github user phrocker closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/405 ---
[GitHub] nifi-minifi-cpp pull request #405: MINIFICPP-618: Add C2 triggers, first of ...
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/405#discussion_r221069962
--- Diff: libminifi/include/properties/Properties.h ---
@@ -60,6 +60,9 @@ class Properties {
// Get the config value
bool get(std::string key, std::string );
+ // Get the config value
--- End diff --
I think you're getting intermediate commits as I work through issues with
another Apache person -- this one isn't quite ready for review. I'll close the
PR in the meantime.
---
[GitHub] nifi-minifi-cpp pull request #405: MINIFICPP-618: Add C2 triggers, first of ...
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/405#discussion_r221068265
--- Diff: libminifi/include/properties/Properties.h ---
@@ -60,6 +60,9 @@ class Properties {
// Get the config value
bool get(std::string key, std::string );
+ // Get the config value
--- End diff --
This should document the alternate keys and why it is different than the
above
---
[GitHub] nifi-minifi-cpp pull request #405: MINIFICPP-618: Add C2 triggers, first of ...
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/405#discussion_r220525598
--- Diff: libminifi/include/c2/C2Trigger.h ---
@@ -0,0 +1,63 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifndef LIBMINIFI_INCLUDE_C2_C2TRIGGER_H_
+#define LIBMINIFI_INCLUDE_C2_C2TRIGGER_H_
+
+#include "core/Connectable.h"
+#include "c2/C2Payload.h"
+#include "properties/Configure.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace c2 {
+
+class C2Trigger : public core::Connectable{
+ public:
+
+ C2Trigger(std::string name, utils::Identifier uuid)
+: core::Connectable(name, uuid){
+
+ }
+ virtual ~C2Trigger() {
+ }
+
+
+ /**
--- End diff --
You were right. I went through and added some comments and probably would
have missed this had you not mentioned it. Thanks! adding some docs now to our
readmes.
Made an early PR to give some people a chance to review and test -- so
really appreciate all input!
---
[GitHub] nifi-minifi-cpp pull request #405: MINIFICPP-618: Add C2 triggers, first of ...
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/405#discussion_r220403308
--- Diff: libminifi/include/c2/C2Trigger.h ---
@@ -0,0 +1,63 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifndef LIBMINIFI_INCLUDE_C2_C2TRIGGER_H_
+#define LIBMINIFI_INCLUDE_C2_C2TRIGGER_H_
+
+#include "core/Connectable.h"
+#include "c2/C2Payload.h"
+#include "properties/Configure.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace c2 {
+
+class C2Trigger : public core::Connectable{
+ public:
+
+ C2Trigger(std::string name, utils::Identifier uuid)
+: core::Connectable(name, uuid){
+
+ }
+ virtual ~C2Trigger() {
+ }
+
+
+ /**
--- End diff --
I think this comment is for a different function
---
[GitHub] nifi-minifi-cpp pull request #405: MINIFICPP-618: Add C2 triggers, first of ...
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/405 MINIFICPP-618: Add C2 triggers, first of which monitors a local file ⦠â¦for changes Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-618 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/405.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #405 commit 44f8fceaa0dbf6d8961ad08af05ae0efb52f9af0 Author: Marc Parisi Date: 2018-09-25T21:45:07Z MINIFICPP-618: Add C2 triggers, first of which monitors a local file for changes ---
