[GitHub] nifi-minifi pull request #88: MINIFI-347: Adding tests for C2 file system ca...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi/pull/88


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #88: MINIFI-347: Adding tests for C2 file system ca...

[jzonthemtn]

Github user jzonthemtn commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/88#discussion_r130586242
  
--- Diff: minifi-assembly/NOTICE ---
@@ -681,6 +681,14 @@ The following binary components are provided under the 
Common Development and Di
 (CDDL 1.0) (GPL3) Streaming API For XML 
(javax.xml.stream:stax-api:jar:1.0-2 - no url provided)
 
 
+Common Public License 1.0
+
+
+The following binary components are provided under the Common Public 
License Version 1.0.  See project link for details.
--- End diff --

Good catch -- I agree with you. I will remove that notice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #88: MINIFI-347: Adding tests for C2 file system ca...

[apiri]

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/88#discussion_r129931863
  
--- Diff: minifi-assembly/NOTICE ---
@@ -681,6 +681,14 @@ The following binary components are provided under the 
Common Development and Di
 (CDDL 1.0) (GPL3) Streaming API For XML 
(javax.xml.stream:stax-api:jar:1.0-2 - no url provided)
 
 
+Common Public License 1.0
+
+
+The following binary components are provided under the Common Public 
License Version 1.0.  See project link for details.
--- End diff --

I believe this is unneeded as it is just a test dependency and neither the 
source of this project nor its binary representation make its way into any of 
the generated distributions (source or convenience binaries).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #88: MINIFI-347: Adding tests for C2 file system ca...

[jzonthemtn]

GitHub user jzonthemtn opened a pull request:

https://github.com/apache/nifi-minifi/pull/88

MINIFI-347: Adding tests for C2 file system cache.

Thank you for submitting a contribution to Apache NiFi - MiNiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi-minifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under minifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under minifi-assembly?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jzonthemtn/nifi-minifi MINIFI-347

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit dc45f748931dca37cc8900df2489febf19a935e0
Author: jzonthemtn 
Date:   2017-07-05T12:53:49Z

MINIFI-347: Adding tests for C2 file system cache.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---