[GitHub] nifi issue #1064: Verifying Controller Service cannot move out of scope

2016-09-28 Thread JPercivall 
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1064
  
+1

Visually verified code and did a contrib check build. In a standalone 
instance configured tried all combinations of configured CS (configured, not, 
invalid ID and no CS) moving up and down multiple process groups. All worked as 
expected, Thanks @mcgilman. I will merge it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1064: Verifying Controller Service cannot move out of scope

2016-09-28 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1064
  
Good call. Will update.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1064: Verifying Controller Service cannot move out of scope

2016-09-27 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1064
  
Thanks @JPercivall, I've updated the logic to verify the move is allowed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1064: Verifying Controller Service cannot move out of scope

2016-09-27 Thread JPercivall 
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1064
  
@mcgilman this properly prevents the processor from being moved up to a 
parent group but it also prevents moving the processor to a child process 
group. Also when I tried moving a processor up a level (but it would still have 
visibility of the CS) I got this NPE in the user logs:


2016-09-27 13:55:39,497 INFO [NiFi Web Server-20] 
org.apache.nifi.web.filter.RequestLogger Attempting request for (anonymous) PUT 
http://localhost:8080/nifi-api/snippets/01571004-5208-1cc8-3233-d96e50118e45 
(source ip: 127.0.0.1)
2016-09-27 13:55:39,506 ERROR [NiFi Web Server-20] 
o.a.nifi.web.api.config.ThrowableMapper An unexpected error has occurred: 
java.lang.NullPointerException. Returning Internal Server Error response.
java.lang.NullPointerException: null
at 
org.apache.nifi.groups.StandardProcessGroup.verifyCanMove(StandardProcessGroup.java:2484)
 ~[nifi-framework-core-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
at 
org.apache.nifi.web.dao.impl.StandardSnippetDAO.verifyUpdateSnippetComponent(StandardSnippetDAO.java:224)
 ~[classes/:na]
at 
org.apache.nifi.web.dao.impl.StandardSnippetDAO.updateSnippetComponents(StandardSnippetDAO.java:231)
 ~[classes/:na]
at 
org.apache.nifi.web.dao.impl.StandardSnippetDAO$$FastClassBySpringCGLIB$$a44196f0.invoke()
 ~[classes/:na]
at 
org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) 
~[spring-core-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:720)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:85)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.apache.nifi.audit.SnippetAuditor.updateSnippetAdvice(SnippetAuditor.java:264)
 ~[classes/:na]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[na:1.8.0_74]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[na:1.8.0_74]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[na:1.8.0_74]
at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_74]
at 
org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:621)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:610)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.aop.aspectj.AspectJAroundAdvice.invoke(AspectJAroundAdvice.java:68)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:168)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:655)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.apache.nifi.web.dao.impl.StandardSnippetDAO$$EnhancerBySpringCGLIB$$e100c2a.updateSnippetComponents()
 ~[classes/:na]
at 
org.apache.nifi.web.StandardNiFiServiceFacade$2.update(StandardNiFiServiceFacade.java:639)
 ~[classes/:1.1.0-SNAPSHOT]
at 
org.apache.nifi.web.revision.NaiveRevisionManager.updateRevision(NaiveRevisionManager.java:121)
 ~[nifi-web-optimistic-locking-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
at 
org.apache.nifi.web.StandardNiFiServiceFacade.updateSnippet(StandardNiFiServiceFacade.java:635)
 ~[classes/:1.1.0-SNAPSHOT]
at 
org.apache.nifi.web.StandardNiFiServiceFacade$$FastClassBySpringCGLIB$$358780e0.invoke()
 ~[classes/:1.1.0-SNAPSHOT]
at 
org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) 
~[spring-core-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:720)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
 ~[spring-aop-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at

[GitHub] nifi issue #1064: Verifying Controller Service cannot move out of scope

2016-09-27 Thread JPercivall 
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1064
  
Reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---