[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/1148 @mauriziocolleluori I've cherry-picked your commits into my branch, and will be submitting a PR that includes your commits along with mine (for [NIFI-4010](https://issues.apache.org/jira/browse/NIFI-4010)). Thank you for your contribution to Apache NiFi! When my PR is merged to master, your PR will be closed along with mine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Github user mauriziocolleluori commented on the issue: https://github.com/apache/nifi/pull/1148 @trixpan @pvillard31 thank you for you comments. I will look into the Kafka processors and revert back once it's done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1148 @mauriziocolleluori thank you for the contribution. any intent on addressing @pvillard31 's comment? While a positive answer is more than welcome, a negative answer is also welcome... all we need to know is if this is ready to review or if you still plan to address the comments. Cheers! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1148 Hi @mauriziocolleluori, If you still encounter issues in UI when testing properties while using expression language, please check that nifi.kerberos.krb5.file is correctly set in your nifi.properties file (and reference a readable file). In addition, it would be great to do the same kind of modification in Kafka processors where Kerberos principal is also a property. Let me know if you are OK to do it, otherwise, I'll do it. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Github user mauriziocolleluori commented on the issue: https://github.com/apache/nifi/pull/1148 I have recompiled and added expression language support (with expected evaluation on read) for both principal and keytab. However when I add any expression language to one of such attributes (in a Hive or HDFS processor on a kerberized Nifi instance) a tooltip says that the attribute has not been set. It looks like some UI validation is still not recognising the expression language as valid. How do I overcome this problem? Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Github user mauriziocolleluori commented on the issue: https://github.com/apache/nifi/pull/1148 Thank you for your feedback, I will add the necessary call to evaluateAttributeExpressions() and submit a new pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1148 Thank you for contributing. In addition to adding the expressionLanguageSupported flag on the property descriptors, we would also need to go through the code and find every place where the properties are evaluated, for example: https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java#L283 And that would need to call evaluateAttributeExpressions(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
