[GitHub] nifi issue #1191: [NIFI-2898] restore ellipsis for processor type, controlle...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1191 Looks good @scottyaslan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1191: [NIFI-2898] restore ellipsis for processor type, controlle...
Github user moranr commented on the issue: https://github.com/apache/nifi/pull/1191 Thanks for the info @scottyaslan â I understand the issue regarding the spacing/height so addressing in a follow on Jira is best. I did just check out the latest and it looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1191: [NIFI-2898] restore ellipsis for processor type, controlle...
Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/1191 @moranr @mcgilman I have updated this PR to also include a 'fix' to the ellipsis plugin for the view state description. @moranr I think you were seeing a caching issue with the scrollable style...anyway, it should be fixed now with the latest update to this PR. Also I was able to apply the styles you suggested in the Jira. Be aware, however, there is an issue with the spacing you outlined in the Jira. The issue is that the ellipsis plugin requires the width and height of the element be set in 'px'. With the responsive nature of the dialogs I do not believe we can support these descriptions as responsive divs that would be necessary to fulfill said spacing (i.e. to support a responsive description area div we would need to apply position:absolute). This will require a much larger effort and as the original ask for NIFI-2898 was to restore the 0.x ellipsis functionality I think we could consider the spacing you outlined as part of a follow on Jira that will support the scrollable description areas (as discussed in https://issues.apache.org/jira/browse/NIFI-2898). Please let me know what you think... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1191: [NIFI-2898] restore ellipsis for processor type, controlle...
Github user moranr commented on the issue: https://github.com/apache/nifi/pull/1191 @mcgilman I think it makes sense to use the ellipsis for view state too. @scottyaslan I'm still seeing the scrollable class applied on the Add Processor description as well, so I can both scroll _and_ hover to see the full description. Also, can we apply the the styling that I outlined in my earlier jira comment to all these areas? This way both behavior and design will be consistent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1191: [NIFI-2898] restore ellipsis for processor type, controlle...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1191 I have verified that the ellipsis have been restored to the descriptions of the new Processor, Controller Service, and Reporting Task table. However, it appears as though we are still using a scrollable area for the View State dialog. Should we make these consistent? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1191: [NIFI-2898] restore ellipsis for processor type, controlle...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1191 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
