[GitHub] nifi issue #1669: NIFI-3695 - created the nifi admin toolkit which includes ...
Github user brosander commented on the issue: https://github.com/apache/nifi/pull/1669 +1 looks good to me, seems to be working, @alopresto did @YolandaMDavis resolve your concerns? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1669: NIFI-3695 - created the nifi admin toolkit which includes ...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1669 @alopresto I addressed the comments to apply LdapName as well as other minor corrections suggested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1669: NIFI-3695 - created the nifi admin toolkit which includes ...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1669 @alopresto thanks so much for your feedback. I've made changes for your review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1669: NIFI-3695 - created the nifi admin toolkit which includes ...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1669 @brosander I've chatted with @thesolson about documentation and she was willing to help there. She will create a separate request in Jira for that effort to add admin-toolkit info to the admin guide. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1669: NIFI-3695 - created the nifi admin toolkit which includes ...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1669 @brosander concerning the binaries they have a very small footprint so I wasn't too concerned about including them (32K, 27K and 1K). I will work to incorporate the cert generation test and documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1669: NIFI-3695 - created the nifi admin toolkit which includes ...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1669 @brosander thanks so much for reviewing! Concerning documentation I do have a link attached. Will also look at the code changes you suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1669: NIFI-3695 - created the nifi admin toolkit which includes ...
Github user brosander commented on the issue: https://github.com/apache/nifi/pull/1669 Hey @YolandaMDavis this looks like a really good addition to the nifi toolkit! Being able to send bulletins and manage nodes via the command line will likely be a really nice-to-have feature for admins. Put feedback above. Please let me know if you need more info. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1669: NIFI-3695 - created the nifi admin toolkit which includes ...
Github user brosander commented on the issue: https://github.com/apache/nifi/pull/1669 We may want to add some usage information to the documentation as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1669: NIFI-3695 - created the nifi admin toolkit which includes ...
Github user brosander commented on the issue: https://github.com/apache/nifi/pull/1669 Would it be difficult to create the other binary resources in test setup? If not it might be preferable to having zips and tars in source control. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1669: NIFI-3695 - created the nifi admin toolkit which includes ...
Github user brosander commented on the issue: https://github.com/apache/nifi/pull/1669 For the keystore, truststores in test resources, is it possible we could use the tls-toolkit to generate those on demand? https://github.com/apache/nifi-minifi/blob/master/minifi-c2/minifi-c2-integration-tests/src/test/java/org/apache/nifi/minifi/c2/integration/test/AbstractTestSecure.java#L71 That should keep them from expiring or needing to be changed later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
