[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1692 +1 LGTM, ran unit tests, verified the processors are in the assembly, and ran some tests on a live NiFi. Thanks for the contribution, this is good stuff! Merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 @mattyb149 just to register: TLSH requires more than 512 characters to work so your hello message triggers a safety mechanism that routes the flow to error. I should have used error but I think I changed this to info during the peer review Should be fixed now  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 pom has also been fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 @alopresto @mattyb149 last two commits should address the two residual issues you identified. One was a simple reference to HashContent.class instead of the fully qualified class path as string. The other one was the use of .info in message too short when it should be error. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 Andy, easy to solve --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1692 @trixpan I have been reviewing this along with @mattyb149 and @bbende and we believe there may be a dependency issue here. I had only reviewed the code design via GitHub but upon trying to build the application, Jetty startup fails with: ``` 2017-05-02 15:01:28,815 WARN [main] org.apache.nifi.web.server.JettyServer Failed to start web server... shutting down. java.lang.ArrayStoreException: sun.reflect.annotation.TypeNotPresentExceptionProxy at sun.reflect.annotation.AnnotationParser.parseClassArray(AnnotationParser.java:724) at sun.reflect.annotation.AnnotationParser.parseArray(AnnotationParser.java:531) at sun.reflect.annotation.AnnotationParser.parseMemberValue(AnnotationParser.java:355) at sun.reflect.annotation.AnnotationParser.parseAnnotation2(AnnotationParser.java:286) at sun.reflect.annotation.AnnotationParser.parseAnnotations2(AnnotationParser.java:120) at sun.reflect.annotation.AnnotationParser.parseAnnotations(AnnotationParser.java:72) at java.lang.Class.createAnnotationData(Class.java:3521) at java.lang.Class.annotationData(Class.java:3510) at java.lang.Class.getAnnotation(Class.java:3415) at java.lang.reflect.AnnotatedElement.isAnnotationPresent(AnnotatedElement.java:258) at java.lang.Class.isAnnotationPresent(Class.java:3425) at org.apache.nifi.nar.ExtensionManager.checkControllerServiceReferenceEligibility(ExtensionManager.java:189) at org.apache.nifi.nar.ExtensionManager.loadExtensions(ExtensionManager.java:160) at org.apache.nifi.nar.ExtensionManager.discoverExtensions(ExtensionManager.java:113) at org.apache.nifi.web.server.JettyServer.start(JettyServer.java:689) at org.apache.nifi.NiFi.(NiFi.java:160) at org.apache.nifi.NiFi.main(NiFi.java:267) ``` After further discussion, we believe this is related to the added dependency on `nifi-standard-processors` in the processor NAR `pom.xml`, which should not be there. I think this needs another iteration to ensure all the wrinkles are ironed out. I don't believe this was requested by the community for this release, so as long as you can continue to get value from it locally, I'll work with you to get it into 1.3.0 but I suggest moving it from this release. Is that ok with you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1692 Will finish reviewing and merge shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1692 Thanks @trixpan . I will continue to review but I appreciate your efforts in response to my comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 @alopresto - I put together the interface based approach and indeed it seems a much cleaner code so thank you for pointing me into this direction. The code has not been optimised and still has a few sharp edges around String split that must be solved before merging but I would appreciate if you could confirm I am moving in the right direction. Once again, thank you for the suggestion. It is certainly a great chance to try to do things "properly". Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 @apiri and now the comparison processor!! For the record: I tried to illustrate the potential of the processor by using two of the NiFi own 'pom.xml' and displaying how despite lack of 1 to 1 match, the processor is still capable of detecting similarities on both cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
