[GitHub] nifi issue #2000: NIFI-4172: renamed ClusteSummaryEntity to ClusterSummaryEn...

2017-07-10 Thread m-hogue
Github user m-hogue commented on the issue:

https://github.com/apache/nifi/pull/2000
  
Closing, to be merged for 2.0.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #2000: NIFI-4172: renamed ClusteSummaryEntity to ClusterSummaryEn...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2000
  
I've updated the fix version on the JIRA so we'll catch it for 2.0.0. 
Unfortunately, I cannot close the PR without a commit. Only the person that 
created the PR can do so. Do you mind closing? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #2000: NIFI-4172: renamed ClusteSummaryEntity to ClusterSummaryEn...

2017-07-10 Thread m-hogue
Github user m-hogue commented on the issue:

https://github.com/apache/nifi/pull/2000
  
Ah, okay. I'd thought the potential for this to be a breaking API change 
prior to making the fix, but I was thinking from a REST API perspective since 
the response type isn't part of a json response.

Feel free to close this. It's fairly trivial, so it's easy to do again 
prior to a major release. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #2000: NIFI-4172: renamed ClusteSummaryEntity to ClusterSummaryEn...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2000
  
Thanks for the PR @m-hogue. I almost made this fix myself awhile back and 
held off. Technically, this class is part of a domain model for the REST API. 
Folks should be able to use this model in conjunction with frameworks like 
Jersey or RestEasy to interact with the REST API. Because of this, we treat 
this as another public API and we don't introduce breaking changes outside of 
major releases. 

Fortunately, the typo is not visible to folks consuming the REST API 
without our DTO domain model (through curl for instance). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---