[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @pvillard31 - The reverting PR is #2064. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @pvillard31 - I will submit a new PR to revert the current bend points behavior later today or tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2009 @yuri1969 - is there a way to submit a PR to revert the behavior when deleting a bend point? Double-click on a bending point opens the connection's configuration instead of deleting it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2009 Sorry about that @yuri1969 I thought we reached consensus that this was expected as long as the current behavior for adding a bend with the double click stayed in tact... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @scottyaslan OK, but I'm afraid the merged version still has the `quickSelect` activated for mid nodes/bends. It seems this should be removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2009 Thanks @yuri1969 this has been merged to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2009 +1 - I'd not change the current behaviour for bends. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 - I find it natural to double-click on the 'line' when I want to add a new bend. - In order to check connection's config I would try to double-click on its rectangular stats box. - Connection's 'nodes' being able to open the config dialog feels OK to me. However, I wouldn't double-click on them intuitively. I have got a Mule Anypoint Studio background so my opinion might be skewed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2009 h I see the problem now...I was thinking the issue is with the actual "line". See, If you right click on the connection's 'line' you get the context menu and can then choose to config/view config so I was thinking we should add that 'quickSelect' open config/view config to the 'line' as well as the 'start', 'end', or 'middle' nodes. The problem with this is that we already have an action for double click on the 'line' (that action is for adding a bend). So maybe @moranr could chime in here Currently the way it is with this PR you can double click the the stats box or an existing bend on a connection's 'line' to open the config dialog for the connection. However, if you double click on the 'line' you will add a bend to the connection rather than opening the connections' config dialog. Is this the expected behavior? Or, do we want to change the current behavior such that when you double click on a 'line' for a connection you will open the connection's config dialog (just like double click everywhere else on a connection) and then we can add an action to the context menu to 'Add Bend' to make it more explicit to the userthoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @scottyaslan Thanks. So the problem is just with the start and end nodes, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2009 I can confirm that currently you can dblclick on a connection's stats box to open the config/view config. You can also (currently) double click any bends in a connection to open the config/view config for that connection. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @scottyaslan It seems I omitted `quickSelect` activation for both start and end "nodes". Please, can you confirm that a double-click displays the connection configuration dialog when performed on a connection's mid "node"? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2009 @yuri1969 everything looks good but I noticed that when double clicking on a connection nothing happens. What I would expect to happen is that the 'Connection Configuration Dialog' should open. I think a quickSelect needs to be activated somewhere in the nf-connection.js when a connection is double clicked... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2009 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
