[GitHub] nifi issue #2087: NIFI-4295: When determining which controller services to r...

2017-08-17 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2087
  
Thanks @markap14! This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2087: NIFI-4295: When determining which controller services to r...

2017-08-17 Thread markap14 
Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2087
  
@mcgilman wow! Sorry about that. Pushed a new commit to address.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2087: NIFI-4295: When determining which controller services to r...

2017-08-16 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2087
  
@markap14 It appears the changes introduced are causing some test failures.

```
Failed tests: 
  TestStandardControllerServiceProvider.validateEnableServices:506 null
  TestStandardControllerServiceProvider.validateEnableServices2:554 null
  
TestStandardControllerServiceProvider.validateEnableServicesWithDisabledMissingService:614
 null

Tests in error: 
  
TestStandardProcessScheduler.testDisableControllerServiceWithProcessorTryingToStartUsingIt:207
 » IllegalState
  
TestStandardControllerServiceProvider.testConcurrencyWithEnablingReferencingServicesGraph:217->testEnableReferencingServicesGraph:261
 » IllegalState
  TestStandardControllerServiceProvider.testEnableDisableWithReference:183 
» IllegalState
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2087: NIFI-4295: When determining which controller services to r...

2017-08-16 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2087
  
Will review...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---