[GitHub] nifi issue #2158: NIFI-4360 Adding support for ADLS Processors. Feature incl...
Github user mohitgargk commented on the issue: https://github.com/apache/nifi/pull/2158 Hi @milanchandna, was wondering if you are still working on this. I need this feature for my use case and was going the same path as you. Seems you are almost there. In case you are working on it, Can you please try syncing your fork and rebase your commits. ---
[GitHub] nifi issue #2158: NIFI-4360 Adding support for ADLS Processors. Feature incl...
Github user milanchandna commented on the issue: https://github.com/apache/nifi/pull/2158 @jzonthemtn @jzonthemtn @pvillard31 Please review. ---
[GitHub] nifi issue #2158: NIFI-4360 Adding support for ADLS Processors. Feature incl...
Github user milanchandna commented on the issue: https://github.com/apache/nifi/pull/2158 Can I please get some feedback here. Thanks. ---
[GitHub] nifi issue #2158: NIFI-4360 Adding support for ADLS Processors. Feature incl...
Github user milanchandna commented on the issue: https://github.com/apache/nifi/pull/2158 @joewitt, @jzonthemtn @pvillard31 - Hey, did you guys got a chance to look at this? ---
[GitHub] nifi issue #2158: NIFI-4360 Adding support for ADLS Processors. Feature incl...
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2158 @milanchandna - you can go in ``nifi-nar-bundles/nifi-azure-bundle`` and build from this directory ``mvn clean install -Pcontrib-check`` ---
[GitHub] nifi issue #2158: NIFI-4360 Adding support for ADLS Processors. Feature incl...
Github user milanchandna commented on the issue: https://github.com/apache/nifi/pull/2158 Hey @pvillard31 Thanks for comments, looking into them. Currently when I am running full build, I am getting failures in TestMinimalLockingWriteAheadLog. testRecoverFileThatHasTrailingNULBytesAndTruncation(org.wali.TestMinimalLockingWriteAheadLog) And because of this not able to reliably detect failures in my own module. Any suggestion to skip the above failures? -Milan. ---
[GitHub] nifi issue #2158: NIFI-4360 Adding support for ADLS Processors. Feature incl...
Github user milanchandna commented on the issue: https://github.com/apache/nifi/pull/2158 Removed the test resource files(as there were license issues) and resolved their dependencies. And there were environment specific characters in test cases. Got rid of them. Please check now. ---
[GitHub] nifi issue #2158: NIFI-4360 Adding support for ADLS Processors. Feature incl...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2158 Lots of test failures. /code Tests run: 19, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.847 sec <<< FAILURE! - in org.apache.nifi.processors.adls.TestPutADLSFile testPutConflictReplace(org.apache.nifi.processors.adls.TestPutADLSFile) Time elapsed: 0.102 sec <<< FAILURE! java.lang.AssertionError: Expected: a string containing "%5Csample%5Csample.txt.nifipart" but: was "/webhdfs/v1/sample/sample.txt.nifipart?op=CREATE=DATA=true=true=3834110d-e3b1-41cc-9ff4-022da542ae4b=3834110d-e3b1-41cc-9ff4-022da542ae4b=2016-11-01" at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:956) at org.junit.Assert.assertThat(Assert.java:923) at org.apache.nifi.processors.adls.TestPutADLSFile.testPutConflictReplace(TestPutADLSFile.java:161) testPutConflictAppend(org.apache.nifi.processors.adls.TestPutADLSFile) Time elapsed: 0.01 sec <<< FAILURE! java.lang.AssertionError: Expected: a string containing "%5Csample%5Csample.txt.nifipart" but: was "/webhdfs/v1/sample/sample.txt.nifipart?op=CREATE=DATA=true=true=0c697d9a-fa07-47b7-adfd-877b90e15717=0c697d9a-fa07-47b7-adfd-877b90e15717=2016-11-01" at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:956) at org.junit.Assert.assertThat(Assert.java:923) at org.apache.nifi.processors.adls.TestPutADLSFile.testPutConflictAppend(TestPutADLSFile.java:215) testPutConflictFail(org.apache.nifi.processors.adls.TestPutADLSFile) Time elapsed: 0 sec <<< FAILURE! java.lang.AssertionError: Expected: a string containing "%5Csample%5Csample.txt.nifipart" but: was "/webhdfs/v1/sample/sample.txt.nifipart?op=CREATE=DATA=true=true=a6fe439c-b2f1-41c2-ba5d-e7d75836d53b=a6fe439c-b2f1-41c2-ba5d-e7d75836d53b=2016-11-01" at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:956) at org.junit.Assert.assertThat(Assert.java:923) at org.apache.nifi.processors.adls.TestPutADLSFile.testPutConflictFail(TestPutADLSFile.java:108) Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.249 sec - in org.apache.nifi.ranger.authorization.TestRangerBasePluginWithPolicies Running org.apache.nifi.ranger.authorization.TestRangerNiFiAuthorizer Results : Failed tests: TestListADLSFile.testFlowFileAttributes:233 expected:<[\]test> but was:<[/]test> TestPutADLSFile.testPutConflictAppend:215 Expected: a string containing "%5Csample%5Csample.txt.nifipart" but: was "/webhdfs/v1/sample/sample.txt.nifipart?op=CREATE=DATA=true=true=0c697d9a-fa07-47b7-adfd-877b90e15717=0c697d9a-fa07-47b7-adfd-877b90e15717=2016-11-01" TestPutADLSFile.testPutConflictFail:108 Expected: a string containing "%5Csample%5Csample.txt.nifipart" but: was "/webhdfs/v1/sample/sample.txt.nifipart?op=CREATE=DATA=true=true=a6fe439c-b2f1-41c2-ba5d-e7d75836d53b=a6fe439c-b2f1-41c2-ba5d-e7d75836d53b=2016-11-01" TestPutADLSFile.testPutConflictReplace:161 Expected: a string containing "%5Csample%5Csample.txt.nifipart" but: was "/webhdfs/v1/sample/sample.txt.nifipart?op=CREATE=DATA=true=true=3834110d-e3b1-41cc-9ff4-022da542ae4b=3834110d-e3b1-41cc-9ff4-022da542ae4b=2016-11-01" ---
[GitHub] nifi issue #2158: NIFI-4360 Adding support for ADLS Processors. Feature incl...
Github user milanchandna commented on the issue: https://github.com/apache/nifi/pull/2158 Thanks @joewitt These test resource files contains Lorem Ipsum text. But anyways I will create my own if required but dont want to delete as they are required for an important test case. Thanks. ---
[GitHub] nifi issue #2158: NIFI-4360 Adding support for ADLS Processors. Feature incl...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2158 @milanchandna am checking into the dependency tree and L Looks good so far. However, please get rid of the davinci and davinci4MB files. The origin of them is unclear and it looks like it comes from common ADLS test files. We have to cite them as source material in such cases. We're better off just making up our own original test files OR removing them altogether. Thanks ---
