[GitHub] nifi issue #2167: NIFI-4403 - add group name to bulletins model & S2S bullet...

2017-09-21 Thread pvillard31
Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2167
  
Thanks @mcgilman - it should be OK now: group name is only on server side 
and only exposed through the reporting task.


---


[GitHub] nifi issue #2167: NIFI-4403 - add group name to bulletins model & S2S bullet...

2017-09-21 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2167
  
That is correct. Knowledge of the components (UUID, status, etc) is 
allowed. Knowledge of what those components are/how they are configured is not.


---


[GitHub] nifi issue #2167: NIFI-4403 - add group name to bulletins model & S2S bullet...

2017-09-21 Thread pvillard31
Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2167
  
Good point. Just to be sure: we allow the user to see the group UUID but we 
don't want to make readable the associated group name. Right? I'll remove the 
group name reference in bulletin entity and bulletin dto.


---


[GitHub] nifi issue #2167: NIFI-4403 - add group name to bulletins model & S2S bullet...

2017-09-21 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2167
  
I don't think we can always add the group name to the BulletinDTO. A user 
could have permissions to the component generating the bulletin but not the 
Process Group the component lives in. Adding it to the Bulletin model 
server-side and exposed via the ReportingContext should ok though.

FYI - The source name is fair game as the BulletinDto is not set in the 
BulletinEntity when they lack permissions to the source. 


---