[GitHub] nifi issue #2201: NIFI-4367 Fix on processor for permit deriving script clas...

2018-02-21 Thread mgaido91 
Github user mgaido91 commented on the issue:

https://github.com/apache/nifi/pull/2201
  
@mattyb149 I think that the test error is unrelated. I run the failing test 
locally and it passes. Do you have further comments for this PR?


---

[GitHub] nifi issue #2201: NIFI-4367 Fix on processor for permit deriving script clas...

2018-02-15 Thread mgaido91 
Github user mgaido91 commented on the issue:

https://github.com/apache/nifi/pull/2201
  
kindly ping @frett27 


---

[GitHub] nifi issue #2201: NIFI-4367 Fix on processor for permit deriving script clas...

2018-01-29 Thread mgaido91 
Github user mgaido91 commented on the issue:

https://github.com/apache/nifi/pull/2201
  
@frett27 I did some more checks and it seems to work. Are you ok if I send 
a PR on your branch to improve the UT? Or can you please update this PR 
according to the comments (and in order to make it passing the tests)? Thanks.


---

[GitHub] nifi issue #2201: NIFI-4367 Fix on processor for permit deriving script clas...

2018-01-25 Thread mgaido91 
Github user mgaido91 commented on the issue:

https://github.com/apache/nifi/pull/2201
  
@frett27 I tried your fix, but if you add custom properties to the scripted 
processor, then it results as invalid with the message:
```
... is not a supported property.
```
Thus a more complete UT might help discovering all the problems and solve 
all of them, because this fix at the moment seems not to be enough to make 
`InvokeScriptedProcessor` working with `AbstractProcessor`.


---