[GitHub] nifi issue #2470: NIFI-4864 Fixing additional resources property pointing to...
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2470 Looks good, @bbende Thank you for reviewing and making the necessary changes :) ---
[GitHub] nifi issue #2470: NIFI-4864 Fixing additional resources property pointing to...
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2470 @zenfenan this seems to be working well, I had a few minor changes I posted here: https://github.com/bbende/nifi/commits/NIFI-4864 If you are good with that last commit I made then I will go ahead and merge this. To summarize my changes... - Changed to using StringUtils.eqausl(oldFingerprintg, newFingerprint) because its possible old fingerprint is null or empty and we would still want to replace it with the new one if we have a new one - Made the reload method synchronized - Removed a the has/get/set fingerprint methods from the interface to try and keep all the fingerprint logic inside of AbstractConfiguredComponent ---
[GitHub] nifi issue #2470: NIFI-4864 Fixing additional resources property pointing to...
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2470 @bbende I made the changes. Got a chance to review this? ---
[GitHub] nifi issue #2470: NIFI-4864 Fixing additional resources property pointing to...
Github user derekstraka commented on the issue: https://github.com/apache/nifi/pull/2470 /cc ijokarumawak ---
