[GitHub] nifi issue #2497: NIFI-3599 Allowed back pressure object count and data size...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2497 @mosermw Looks great! Thanks, this has been merged to master. ---
[GitHub] nifi issue #2497: NIFI-3599 Allowed back pressure object count and data size...
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2497 Hi @mcgilman I made the suggested changes, rebased from master, and force pushed to this branch. What do you think? ---
[GitHub] nifi issue #2497: NIFI-3599 Allowed back pressure object count and data size...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2497 @mosermw Didn't really have a great option... so the suggestion was ultimately a compromise. The idea was that About returns information about this instance of NiFi. This could include some configuration like the defaultBackpressThreshold. We could eventually move other things like the content viewer URL in there too. ---
[GitHub] nifi issue #2497: NIFI-3599 Allowed back pressure object count and data size...
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2497 @mcgilma @markap14 I'm not sure I was able to fully grok "add a ConfigDTO which is set on the AboutDTO" but I gave it a shot. Rebased from master and pushed a new commit. Let me know what you think, thanks! ---
[GitHub] nifi issue #2497: NIFI-3599 Allowed back pressure object count and data size...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2497 @mosermw @markap14 It's kind of a gray area. I suggested an endpoint like the /nifi-api/flow/about because that seemed like the best fit currently and was obviously trying to avoid requiring another request to load the UI. I'm a little hesitant to go the route of a /nifi-api/flow/properties endpoint because I'm not sure that's a concept we want to advertise/expose. I don't mind doing something more generic, but what if the concept was more related to default values or config. This is something that any client using the API may want to know ahead of time for this reason exactly. Would adding a DefaultsDTO or ConfigDTO which is set on the AboutDTO fit a little better? ---
[GitHub] nifi issue #2497: NIFI-3599 Allowed back pressure object count and data size...
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2497 @markap14 and @mcgilman I did consider that backpressure settings didn't really belong in AboutDTO. The BannerDTO also pulls information from nifi.properties, but I didn't think backpressure fit there either. I didn't want to further expand the API by adding something like BackpressureDTO at a /nifi-api/flow/backpressure endpoint, but maybe that's the preferred approach? Or perhaps a PropertiesDTO at /nifi-api/flow/properties to do something more generic? ---
[GitHub] nifi issue #2497: NIFI-3599 Allowed back pressure object count and data size...
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2497 @mosermw I think this is a pretty reasonable change. The only thing that gives me pause is putting this information into AboutDTO. To me, it doesn't feel like the right place for this kind of information. Admittedly, I don't know off the top of my head where would be the best place for it. @mcgilman do you have any thoughts on where something like that should go? ---
