[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

[mattyb149]

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2575
  
+1 LGTM, ran full build with unit tests and tried Ambari Format as well as 
Record Format with an AvroRecordSetWriter. Verified the records are in the 
prescribed format and the standard S2S reporting task attributes are correct. 
Also the documentation is great, thanks for this addition! Merging to master


---

[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

[pvillard31]

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2575
  
Done, thanks @mattyb149 !


---

[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

[mattyb149]

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2575
  
Mind doing another rebase? I will review shortly thereafter, thanks!


---

[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

[pvillard31]

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2575
  
Both issues seem to be resolved on master, I have rebased against master.


---

[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

[mattyb149]

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2575
  
I saw the "unable to find schema" issue in the last PR too, it seems to be 
related to the onPropertyModified() method of AvroSchemaRegistry, that's where 
the actual schemas get populated, but while debugging I saw that the name was 
in the schema map but there was no actual schema stored. Not sure if this is a 
lifecycle order-of-operations thing or not, but when I deleted the schema from 
the registry, saved it, then added it back, it worked. Just some extra info 
while you're pathfinding :)


---