[GitHub] nifi issue #2847: NIFI-5377 prevent infinite loop if a controller service ci...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2847 Thanks @markobean and @markap14. These have been merged to master. ---
[GitHub] nifi issue #2847: NIFI-5377 prevent infinite loop if a controller service ci...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2847 Thanks @markap14! I'll pull down this PR and apply your patch for reviewing purposes. ---
[GitHub] nifi issue #2847: NIFI-5377 prevent infinite loop if a controller service ci...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2847 @JonathanKessler I experienced it on the graph. If you add another service (like I described) you should be able to enable the service with no dependencies. As part of that action, you can indicate whether you want referencing services to also be enabled. ---
[GitHub] nifi issue #2847: NIFI-5377 prevent infinite loop if a controller service ci...
Github user JonathanKessler commented on the issue: https://github.com/apache/nifi/pull/2847 @mcgilman Did you experience this behavior on the graph or in a unit test? After fixing the infinite loop locally I was never able to enable the controller services on the graph because they were never valid: A depends on B which depends on A. A is not enabled so B cannot be enabled and vice versa. ---
[GitHub] nifi issue #2847: NIFI-5377 prevent infinite loop if a controller service ci...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2847 @markobean Thanks for the PR! I've tried running it and it does indeed address the issue called out in the JIRA. Previously, the infinite loop occurred when trying to configure the services in question. With the PR in place, I can now configure the services to build the reference cycle. However, if I try to enable them I encountered a different infinite loop here: at org.apache.nifi.controller.service.StandardControllerServiceReference.findRecursiveReferences(StandardControllerServiceReference.java:125) I also seem to recall that previously the framework would identify when a reference cycle was detected and it would set that flag in the `ControllerServiceReferencingComponentDTO`. I noticed in the UI after establishing the reference cycle, the framework did not appear to detect it. This may or may not be related to the infinite loop referenced above. I do not believe this infinite loop is a result of this PR, but it's something we should probably address now as well. In my scenario service A did not reference any other service, service B referenced service A and C, and service C referenced service B. In your testing, did you happen to hit the same loop I did when trying to enable them? ---
[GitHub] nifi issue #2847: NIFI-5377 prevent infinite loop if a controller service ci...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2847 Will review ---
