[GitHub] nifi issue #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v26.0-jr...
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2977 Discovered issues within the core nifi framework related to guava, zookeeper and curator. Unable to bump guava without upgrading the others. This is a bigger task that just upgrading guava. ---
[GitHub] nifi issue #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v26.0-jr...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2977 Happy to help review this PR once it's ready. ---
[GitHub] nifi issue #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v26.0-jr...
Github user thenatog commented on the issue: https://github.com/apache/nifi/pull/2977 Updating this PR, don't merge. ---
[GitHub] nifi issue #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v26.0-jr...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2977 Reviewing... ---
[GitHub] nifi issue #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v26.0-jr...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2977 Saw @bbende's jira comment: > We should only update Guava dependencies that we directly use in our own code, but not transitive dependencies used by client libraries (i.e. do not change the Guava version for things like Hadoop processors, or HBase processors, etc.). I saw Kudu, Kite and Ignite get updated, but according to `mvn dependency:tree` they're not transitive. So I'm putting this here for documentation purposes. Overall LGTM but will take another look tomorrow. ---
[GitHub] nifi issue #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v26.0-jr...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2977 @joewitt just checked the license on google/guava and it's still ASL so I think L is clear on this. ---
