[GitHub] nifi issue #2997: NIFI-5583: Add cdc processor for MySQL referring to GTID.

2018-10-21 Thread yoshiata 
Github user yoshiata commented on the issue:

https://github.com/apache/nifi/pull/2997
  
Fixed existing processor. Please re-review.


---

[GitHub] nifi issue #2997: NIFI-5583: Add cdc processor for MySQL referring to GTID.

2018-10-09 Thread yoshiata 
Github user yoshiata commented on the issue:

https://github.com/apache/nifi/pull/2997
  
We need no separate processor.
I added a saparate processor because I was concerned that adding code to 
existing processors would make complicated.
I will change to add code to existing processors.


---

[GitHub] nifi issue #2997: NIFI-5583: Add cdc processor for MySQL referring to GTID.

2018-10-09 Thread mattyb149 
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2997
  
Do we need a separate processor for this, or can we just add GTID support 
to the existing one (perhaps with a property such as "Include GTID" or 
whatever, defaulting to false but if set to true, executes the GTID-related 
code)?


---

[GitHub] nifi issue #2997: NIFI-5583: Add cdc processor for MySQL referring to GTID.

2018-10-02 Thread yoshiata 
Github user yoshiata commented on the issue:

https://github.com/apache/nifi/pull/2997
  
Unit tests added. Please review.


---

[GitHub] nifi issue #2997: NIFI-5583: Add cdc processor for MySQL referring to GTID.

2018-09-10 Thread yoshiata 
Github user yoshiata commented on the issue:

https://github.com/apache/nifi/pull/2997
  
I will add unit tests later.


---