[GitHub] nifi issue #2999: NIFI-5589 : Clarify PutMongo documentation
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2999 Merged. Thanks for the contribution. ---
[GitHub] nifi issue #2999: NIFI-5589 : Clarify PutMongo documentation
Github user josephxsxn commented on the issue: https://github.com/apache/nifi/pull/2999 Thanks for helping with this @MikeThomsen, Our dev team spent a long time trying to understand exactly how to use the processor and so we hope these clarifications will save someone else in the future :) Once you know its very straight forward. ---
[GitHub] nifi issue #2999: NIFI-5589 : Clarify PutMongo documentation
Github user VijetaH commented on the issue: https://github.com/apache/nifi/pull/2999 @MikeThomsen Could you please review MongoDB document changes? ---
[GitHub] nifi issue #2999: NIFI-5589 : Clarify PutMongo documentation
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2999 I looked at the code, and the documentation change is syntactically valid, but I am not familiar enough with MongoDB to assert that the content is correct. You will need a reviewer who is a MongoDB user. There are a few in the community and they look for PRs with _Mongo_ in the title quite regularly. ---
[GitHub] nifi issue #2999: NIFI-5589 : Clarify PutMongo documentation
Github user VijetaH commented on the issue: https://github.com/apache/nifi/pull/2999 @alopresto Can you please review the changes? ---
[GitHub] nifi issue #2999: NIFI-5589 : Clarify PutMongo documentation
Github user josephxsxn commented on the issue: https://github.com/apache/nifi/pull/2999 @alopresto Thanks Andy :) nice to hear that changed, I always thought it was tedious to squash things. ---
[GitHub] nifi issue #2999: NIFI-5589 : Clarify PutMongo documentation
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2999 Hi @josephxsxn I don't think we have to request that any more as GitHub shows the consolidated diff in one view, and rebasing & force-pushing to a branch that is used for a PR destroys history and can mess up the reviewer comments. The committer rebases & squashes the commits when they merge them. ---
[GitHub] nifi issue #2999: NIFI-5589 : Clarify PutMongo documentation
Github user josephxsxn commented on the issue: https://github.com/apache/nifi/pull/2999 Thanks for submitting this documentation change. Can you please squash all 3 of your commits into 1? https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit ---
