[GitHub] nifi issue #3046: NIFI-5661: Adding Load Balance config UI

2018-10-11 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/3046
  
Thanks @ijokarumawak! This has been merged to master.


---

[GitHub] nifi issue #3046: NIFI-5661: Adding Load Balance config UI

2018-10-10 Thread ijokarumawak 
Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/3046
  
@mcgilman I understand that. I moved the combo options to `nfCommon`. Hope 
this PR looks good now. Thanks!


---

[GitHub] nifi issue #3046: NIFI-5661: Adding Load Balance config UI

2018-10-10 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/3046
  
Thanks for the update. We do not want to reference another module directly 
via `nf.`. This would only be working currently because we have not enabled a 
module loader yet. However, the codebase currently supports one. This can be 
seen at the top of any of the JS files. If a module loader was turned on, this 
would fail because the `nf.` namespace would no longer be in global scope.

If you want to reference something in another module, we'll need to import 
it. Alternatively, you could import it in a module that is already imported in 
both. In the policy case, the combo options are in `nfCommon` and a utility 
function was added to access them.


---

[GitHub] nifi issue #3046: NIFI-5661: Adding Load Balance config UI

2018-10-09 Thread ijokarumawak 
Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/3046
  
@mcgilman Thanks for finding the combo option text issue. I hadn't tested 
the dialog from summary. Fixed the issue by moving the options to 
nf-connection-detail.js so that nf-connection-configuration.js can also use the 
same option array.


---

[GitHub] nifi issue #3046: NIFI-5661: Adding Load Balance config UI

2018-10-08 Thread ijokarumawak 
Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/3046
  
@mcgilman Thank you for reviewing! Incorporated the comments.


---

[GitHub] nifi issue #3046: NIFI-5661: Adding Load Balance config UI

2018-10-05 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/3046
  
Will review...


---