[GitHub] nifi issue #571: NIFI-2208 - Support Custom Properties in Expression Languag...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/571 Thanks so much @JPercivall ! Will take care of closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #571: NIFI-2208 - Support Custom Properties in Expression Languag...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/571 Whops accidentally mistyped the close statement but I merged it in[1]. @YolandaMDavis could you close this? [1] https://github.com/apache/nifi/commit/8412d2662ae1cab6c52be62272a2971d199719df --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #571: NIFI-2208 - Support Custom Properties in Expression Languag...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/571 Yup let's make another ticket for the documentation and just address what was already merged into 0.x +1 Visually verified code and did a contrib check build. In standalone and a secure cluster I used the below template (rename to xml) to test various levels of the EL access and all performed as expected. Thanks @YolandaMDavis, I will merge it in. [Variable_Registry_test.txt](https://github.com/apache/nifi/files/391396/Variable_Registry_test.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #571: NIFI-2208 - Support Custom Properties in Expression Languag...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/571 @JPercivall thanks for the review! Just wanted to add a couple of notes on questions you had above: > @YolandaMDavis, what happens if an incoming FlowFile, FileVariableRegistry and custom EL attributes all have the same key? Is there any ordering enforced? From looking at the code, I believe it to be random. > The order is dictated through the MultiMap's (now ImmutableMultiMap) use of an ArrayList internally which maintains the order in which a map was added to that list. In the case you mentioned where the same key name appears across a flow file, file/property registry etc the first map encountered in the ImmutableMultiMap's list with that value will be used. When the variable registry is initialized via VariableRegistryUtils (as it is in most of the application) environment variables and java application properties are added first, with those values taking precedence. The details of this will be added to the admin guide (which I believe is part of another issue on Jira list, but I can confirm). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #571: NIFI-2208 - Support Custom Properties in Expression Languag...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/571 @alopresto here is a write up of use case and demo of example flow (also refers to a gist with files from demo) [Supporting Custom Properties for Expression Languages.docx](https://github.com/apache/nifi/files/366969/Supporting.Custom.Properties.for.Expression.Languages.docx) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #571: NIFI-2208 - Support Custom Properties in Expression Languag...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/571 thanks @alopresto I just rebased with the latest to remove conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #571: NIFI-2208 - Support Custom Properties in Expression Languag...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/571 I will review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #571: NIFI-2208 - Support Custom Properties in Expression Languag...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/571 Hey @YolandaMDavis, looks like this has merge conflicts. Could you update the PR to the latest master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
