[GitHub] nifi issue #869: NIFI-2576 - PutSQL assumes all Timestamps are provided in E...
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/869 Thanks for update, merged to master! Just an FYI, I had a bit of trouble getting the changes to apply from the PR onto master... for future it would be easiest to have a specific branch with only one commit for the initial PR, rather than submitting from your master to NiFi master. Thanks again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #869: NIFI-2576 - PutSQL assumes all Timestamps are provided in E...
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/869 I can go for that. Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #869: NIFI-2576 - PutSQL assumes all Timestamps are provided in E...
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/869 @patricker thanks for the contribution! Definitely makes sense to support both formats... What do you think about using a regex to determine if it is a long, and if so then parseLong, otherwise attempt to parse a date? (could be the other way around, but I was thinking the regex for a long is easiest) I'm thinking of the case where someone is always sending in longs and it is continuously throwing/catching the parse exception, that may end up being expensive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---