[GitHub] nifi pull request #1067: NIFI-2639 Update NiFi In Depth Doc: made text edits...

[JPercivall]

Github user JPercivall commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1067#discussion_r80725420
  
--- Diff: nifi-docs/src/main/asciidoc/nifi-in-depth.adoc ---
@@ -34,26 +34,28 @@ There are three repositories that are utilized by NiFi. 
Each exists within the O
 - The Content Repository holds the content for current and past FlowFiles.
 - The Provenance Repository holds the history of FlowFiles.
 
-image::NiFiArchitecture.png["NiFi Architecture Diagram"]
+image::zero-master-node.png["NiFi Architecture Diagram"]
--- End diff --

Rgr, I will remove it, double check it wasn't referenced by anything, amend 
the removal to your commit and push.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1067: NIFI-2639 Update NiFi In Depth Doc: made text edits...

[andrewmlim]

Github user andrewmlim commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1067#discussion_r80724244
  
--- Diff: nifi-docs/src/main/asciidoc/nifi-in-depth.adoc ---
@@ -34,26 +34,28 @@ There are three repositories that are utilized by NiFi. 
Each exists within the O
 - The Content Repository holds the content for current and past FlowFiles.
 - The Provenance Repository holds the history of FlowFiles.
 
-image::NiFiArchitecture.png["NiFi Architecture Diagram"]
+image::zero-master-node.png["NiFi Architecture Diagram"]
--- End diff --

Good catch.  Yes, let's remove that obsoleted image. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1067: NIFI-2639 Update NiFi In Depth Doc: made text edits...

[JPercivall]

Github user JPercivall commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1067#discussion_r80723831
  
--- Diff: nifi-docs/src/main/asciidoc/nifi-in-depth.adoc ---
@@ -34,26 +34,28 @@ There are three repositories that are utilized by NiFi. 
Each exists within the O
 - The Content Repository holds the content for current and past FlowFiles.
 - The Provenance Repository holds the history of FlowFiles.
 
-image::NiFiArchitecture.png["NiFi Architecture Diagram"]
+image::zero-master-node.png["NiFi Architecture Diagram"]
--- End diff --

Ah one thing I almost missed, can I remove the NiFiArchitecture.png image? 
I don't see it referenced anywhere else. I can just amend it to your commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1067: NIFI-2639 Update NiFi In Depth Doc: made text edits...

[andrewmlim]

GitHub user andrewmlim opened a pull request:

https://github.com/apache/nifi/pull/1067

NIFI-2639 Update NiFi In Depth Doc: made text edits and replaced scre…

…enshots with new UI

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrewmlim/nifi NIFI-2639

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1067.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1067


commit 2c059471a30d59b022cfd787031fd196d45a6e55
Author: Andrew Lim 
Date:   2016-09-26T18:36:55Z

NIFI-2639 Update NiFi In Depth Doc: made text edits and replaced 
screenshots with new UI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---