[GitHub] nifi pull request #1971: NIFI-3193: added ability to authenticate with AMQP ...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1971 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1971: NIFI-3193: added ability to authenticate with AMQP ...
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/1971#discussion_r125669424 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/resources/docs/org.apache.nifi.amqp.processors.ConsumeAMQP/additionalDetails.html --- @@ -63,6 +63,9 @@ Password - [REQUIRED] password to use with user name to connect to AMQP broker. Usually provided by the administrator. Defaults to 'guest'. +Cert Authentication - [OPTIONAL] whether or not to use the SSL certificate for authentication rather than user name and password. --- End diff -- Would it be possible to have this match the displayName text? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1971: NIFI-3193: added ability to authenticate with AMQP ...
Github user m-hogue commented on a diff in the pull request: https://github.com/apache/nifi/pull/1971#discussion_r125505285 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPPublisher.java --- @@ -16,14 +16,14 @@ */ package org.apache.nifi.amqp.processors; -import java.io.IOException; - -import org.apache.nifi.logging.ComponentLog; --- End diff -- Yeah, I'll make sure to avoid this in the future as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1971: NIFI-3193: added ability to authenticate with AMQP ...
Github user m-hogue commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1971#discussion_r125505175
--- Diff:
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java
---
@@ -97,6 +98,14 @@
.required(false)
.identifiesControllerService(SSLContextService.class)
.build();
+public static final PropertyDescriptor USE_CERT_AUTHENTICATION = new
PropertyDescriptor.Builder()
+.name("Cert Authentication")
--- End diff --
Yes, no problem!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1971: NIFI-3193: added ability to authenticate with AMQP ...
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1971#discussion_r125421693
--- Diff:
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java
---
@@ -97,6 +98,14 @@
.required(false)
.identifiesControllerService(SSLContextService.class)
.build();
+public static final PropertyDescriptor USE_CERT_AUTHENTICATION = new
PropertyDescriptor.Builder()
+.name("Cert Authentication")
--- End diff --
Could you use ``.displayName()`` for what is displayed on the UI? and
``.name`` for a more "computer-friendly" name? It's not mandatory but that's a
convention we are trying to progressively adopt.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1971: NIFI-3193: added ability to authenticate with AMQP ...
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1971#discussion_r125421301 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPPublisher.java --- @@ -16,14 +16,14 @@ */ package org.apache.nifi.amqp.processors; -import java.io.IOException; - -import org.apache.nifi.logging.ComponentLog; --- End diff -- Hey @m-hogue, thanks for this PR. Can you take care of the not needed changes that have been (most likely) introduced by your IDE? For example this class is marked as changed but there is no actual change in it. It's similar for some files modified by your PR. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
