[GitHub] nifi pull request #2499: Nifi-4918 JMS Connection Factory setting the dynami...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2499


---

[GitHub] nifi pull request #2499: Nifi-4918 JMS Connection Factory setting the dynami...

[jugi92]

GitHub user jugi92 reopened a pull request:

https://github.com/apache/nifi/pull/2499

Nifi-4918 JMS Connection Factory setting the dynamic Properties wrong

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jugi92/nifi NIFI-4918

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2499


commit d3e62ed82acc856681d94da559060b5ce823e961
Author: Julian Gimbel 
Date:   2018-02-28T12:39:32Z

looping over several methods to try and fit the dynamic attribute.
If failed, use first method and throw error if not working.

commit 255c8478fb2b4957bcc49c41ca069149387f3b32
Author: Julian Gimbel 
Date:   2018-02-28T12:39:32Z

NIFI-4918 JMS Connection Factory setting the dynamic Properties wrong.
Now looping over several methods to try and fit the dynamic attribute.
If failed, use first method and throw error if not working.

commit 7446c9e5f447a4669a89bb87ec509fd70606b91f
Author: Julian Gimbel 
Date:   2018-02-28T16:12:27Z

Merge branch 'NIFI-4918' of https://github.com/jugi92/nifi into NIFI-4918




---

[GitHub] nifi pull request #2499: Nifi-4918 JMS Connection Factory setting the dynami...

[jugi92]

Github user jugi92 closed the pull request at:

https://github.com/apache/nifi/pull/2499


---

[GitHub] nifi pull request #2499: Nifi-4918 JMS Connection Factory setting the dynami...

[jugi92]

Github user jugi92 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2499#discussion_r171875056
  
--- Diff: 
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/cf/JMSConnectionFactoryProvider.java
 ---
@@ -257,21 +256,26 @@ private void 
setConnectionFactoryProperties(ConfigurationContext context) {
  */
 private void setProperty(String propertyName, Object propertyValue) {
 String methodName = this.toMethodName(propertyName);
-Method method = Utils.findMethod(methodName, 
this.connectionFactory.getClass());
-if (method != null) {
+Method[] methods = Utils.findMethods(methodName, 
this.connectionFactory.getClass());
+if (methods != null && methods.length < 0) {
--- End diff --

Yes sorry, it was supposed to be methods.length > 0
I will change and open a new pull request


---

[GitHub] nifi pull request #2499: Nifi-4918 JMS Connection Factory setting the dynami...

[markap14]

Github user markap14 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2499#discussion_r171863515
  
--- Diff: 
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/cf/JMSConnectionFactoryProvider.java
 ---
@@ -257,21 +256,26 @@ private void 
setConnectionFactoryProperties(ConfigurationContext context) {
  */
 private void setProperty(String propertyName, Object propertyValue) {
 String methodName = this.toMethodName(propertyName);
-Method method = Utils.findMethod(methodName, 
this.connectionFactory.getClass());
-if (method != null) {
+Method[] methods = Utils.findMethods(methodName, 
this.connectionFactory.getClass());
+if (methods != null && methods.length < 0) {
--- End diff --

methods.length can never be less than 0 here... was that supposed to be > 0 
perhaps?


---

[GitHub] nifi pull request #2499: Nifi-4918 JMS Connection Factory setting the dynami...

[jugi92]

GitHub user jugi92 opened a pull request:

https://github.com/apache/nifi/pull/2499

Nifi-4918 JMS Connection Factory setting the dynamic Properties wrong

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jugi92/nifi NIFI-4918

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2499


commit d3e62ed82acc856681d94da559060b5ce823e961
Author: Julian Gimbel 
Date:   2018-02-28T12:39:32Z

looping over several methods to try and fit the dynamic attribute.
If failed, use first method and throw error if not working.

commit 255c8478fb2b4957bcc49c41ca069149387f3b32
Author: Julian Gimbel 
Date:   2018-02-28T12:39:32Z

NIFI-4918 JMS Connection Factory setting the dynamic Properties wrong.
Now looping over several methods to try and fit the dynamic attribute.
If failed, use first method and throw error if not working.

commit 7446c9e5f447a4669a89bb87ec509fd70606b91f
Author: Julian Gimbel 
Date:   2018-02-28T16:12:27Z

Merge branch 'NIFI-4918' of https://github.com/jugi92/nifi into NIFI-4918




---