[GitHub] nifi pull request #2984: NIFI-5569 Added keywords to Route* and ScanAttribut...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2984


---

[GitHub] nifi pull request #2984: NIFI-5569 Added keywords to Route* and ScanAttribut...

[alopresto]

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2984#discussion_r214774007
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteText.java
 ---
@@ -655,14 +653,9 @@ public boolean equals(Object obj) {
 
 Group other = (Group) obj;
 if (capturedValues == null) {
-if (other.capturedValues != null) {
-return false;
-}
-} else if (!capturedValues.equals(other.capturedValues)) {
-return false;
-}
+return other.capturedValues == null;
+} else return capturedValues.equals(other.capturedValues);
--- End diff --

This was an automatic IDE optimization I wasn't aware of, but the logic 
checks out. 


---

[GitHub] nifi pull request #2984: NIFI-5569 Added keywords to Route* and ScanAttribut...

[alopresto]

GitHub user alopresto opened a pull request:

https://github.com/apache/nifi/pull/2984

NIFI-5569 Added keywords to Route* and ScanAttribute processors to im…

…prove discoverability.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alopresto/nifi NIFI-5569

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2984.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2984


commit a4369b0a781fc15ed03438c1bcf4257942c28586
Author: Andy LoPresto 
Date:   2018-09-04T02:12:56Z

NIFI-5569 Added keywords to Route* and ScanAttribute processors to improve 
discoverability.




---