[GitHub] nifi pull request #3098: NIFI-5728 XML Writer to populate record tag name pr...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3098 ---
[GitHub] nifi pull request #3098: NIFI-5728 XML Writer to populate record tag name pr...
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3098#discussion_r230024436
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestXMLRecordSetWriter.java
---
@@ -116,6 +124,34 @@ public void testRootAndRecordNaming() throws
IOException, InitializationExceptio
assertThat(expected,
CompareMatcher.isSimilarTo(actual).ignoreWhitespace().withNodeMatcher(new
DefaultNodeMatcher(ElementSelectors.byNameAndText)));
}
+@Test
+public void testSchemaRootRecordNaming() throws IOException,
InitializationException {
+String avroSchemaText = new
String(Files.readAllBytes(Paths.get("src/test/resources/xml/testschema3")));;
+Schema avroSchema = new Schema.Parser().parse(avroSchemaText);
+
+SchemaIdentifier schemaId =
SchemaIdentifier.builder().name("schemaName").build();
+RecordSchema recordSchema = AvroTypeUtil.createSchema(avroSchema,
avroSchemaText, schemaId);
+
+XMLRecordSetWriter writer = new _XMLRecordSetWriter(recordSchema);
+TestRunner runner = setup(writer);
+
+runner.setProperty(writer, XMLRecordSetWriter.ROOT_TAG_NAME,
"ROOT_NODE");
+//runner.setProperty(writer, XMLRecordSetWriter.RECORD_TAG_NAME,
"RECORD_NODE");
--- End diff --
to remove?
---
[GitHub] nifi pull request #3098: NIFI-5728 XML Writer to populate record tag name pr...
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3098#discussion_r227674603
--- Diff:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/SimpleRecordSchema.java
---
@@ -213,4 +215,30 @@ public String toString() {
public SchemaIdentifier getIdentifier() {
return schemaIdentifier;
}
+
+/**
+ * Set schema name.
+ * @param schemaName schema name as defined in a root record.
+ */
+public void setSchemaName(String schemaName) {
+this.schemaName = schemaName;
+}
+
+@Override
+public Optional getSchemaName() {
+return Optional.ofNullable(schemaName);
+}
+
+/**
+ * Set schema namespace.
+ * @param schemaNamespace schema name as defined in a root record.
--- End diff --
schema namespace
---
[GitHub] nifi pull request #3098: NIFI-5728 XML Writer to populate record tag name pr...
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/3098 NIFI-5728 XML Writer to populate record tag name properly All the changes are tested against - "Use Schema Text" (regression) - "AvroSchemaRegistry" Controller Service - "Hortonworks Schema Registry" Controller Service (docker). Also added Test Case to handle scenario when schema name in xxxRegistry Controller Service doesn't mach "name" field of the root record in schema text. --- Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bdesert/nifi NIFI-5728_XMLWriter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3098.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3098 commit 268ae74deeaf0228fb07cf50c3dd343ff9fb7e9f Author: Ed B Date: 2018-10-21T01:42:21Z NIFI-5728 XML Writer to populate record tag name properly ---
