[GitHub] nifi pull request #3125: NIFI-5677 Added note to clarify why modifying/creat...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3125 ---
[GitHub] nifi pull request #3125: NIFI-5677 Added note to clarify why modifying/creat...
Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi/pull/3125#discussion_r230824217 --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc --- @@ -1928,7 +1928,9 @@ The following actions are not considered local changes: * modifying sensitive property values * modifying remote process group URLs * updating a processor that was referencing a non-existent controller service to reference an externally available controller service -* modifying variables +* creating or modifying variables --- End diff -- Added "deleting variables" scenario. PR read for review/merge if no other issues raised. Thanks @ijokarumawak ! ---
[GitHub] nifi pull request #3125: NIFI-5677 Added note to clarify why modifying/creat...
Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi/pull/3125#discussion_r230820448 --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc --- @@ -1928,7 +1928,9 @@ The following actions are not considered local changes: * modifying sensitive property values * modifying remote process group URLs * updating a processor that was referencing a non-existent controller service to reference an externally available controller service -* modifying variables +* creating or modifying variables --- End diff -- That's a good point. Will add that scenario. ---
[GitHub] nifi pull request #3125: NIFI-5677 Added note to clarify why modifying/creat...
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/3125#discussion_r230623728 --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc --- @@ -1928,7 +1928,9 @@ The following actions are not considered local changes: * modifying sensitive property values * modifying remote process group URLs * updating a processor that was referencing a non-existent controller service to reference an externally available controller service -* modifying variables +* creating or modifying variables --- End diff -- A bit nit-picky, but how about deleting variables? ---
