[GitHub] patricker commented on a change in pull request #3203: NIFI-5871 ignore UUID attribute when copying flow file attributes
patricker commented on a change in pull request #3203: NIFI-5871 ignore UUID
attribute when copying flow file attributes
URL: https://github.com/apache/nifi/pull/3203#discussion_r243071420
##
File path:
nifi-nar-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/test/java/org/apache/nifi/processors/couchbase/TestPutCouchbaseKey.java
##
@@ -268,7 +268,7 @@ public void testInputFlowFileUuid() throws Exception {
ArgumentCaptor capture =
ArgumentCaptor.forClass(RawJsonDocument.class);
verify(bucket, times(1)).upsert(capture.capture(), eq(PersistTo.NONE),
eq(ReplicateTo.NONE));
-assertEquals(uuid, capture.getValue().id());
+// assertEquals(uuid, capture.getValue().id());
Review comment:
No, I want you to completely delete the line of code instead of commenting
it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] patricker commented on a change in pull request #3203: NIFI-5871 ignore UUID attribute when copying flow file attributes
patricker commented on a change in pull request #3203: NIFI-5871 ignore UUID
attribute when copying flow file attributes
URL: https://github.com/apache/nifi/pull/3203#discussion_r243059052
##
File path:
nifi-nar-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/test/java/org/apache/nifi/processors/couchbase/TestPutCouchbaseKey.java
##
@@ -268,7 +268,7 @@ public void testInputFlowFileUuid() throws Exception {
ArgumentCaptor capture =
ArgumentCaptor.forClass(RawJsonDocument.class);
verify(bucket, times(1)).upsert(capture.capture(), eq(PersistTo.NONE),
eq(ReplicateTo.NONE));
-assertEquals(uuid, capture.getValue().id());
+// assertEquals(uuid, capture.getValue().id());
Review comment:
If you drop all of these commented lines, I'll go ahead and merge this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
