Re: [PR] MINIFICPP-2344 Update version number to 1.0.0 [nifi-minifi-cpp]
lordgamez commented on PR #1769: URL: https://github.com/apache/nifi-minifi-cpp/pull/1769#issuecomment-2077025996 > It would be nice to be able to differentiate between this and future versions, like 1.0 proper, but I didn't find any way to convince CMake to add something other than a number at the end. Any ideas? Unfortunately I had the same problem, I didn't find any solution for it in CMake either. I was thinking we could keep the version 1.0.0 here and only tag it with the `-M1` suffix in the git tag and convenience binaries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2344 Update version number to 1.0.0 [nifi-minifi-cpp]
szaszm commented on PR #1769: URL: https://github.com/apache/nifi-minifi-cpp/pull/1769#issuecomment-2077004610 It would be nice to be able to differentiate between this and future versions, like 1.0 proper, but I didn't find any way to convince CMake to add something other than a number at the end. Any ideas? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2344 Update version number to 1.0.0 [nifi-minifi-cpp]
lordgamez commented on code in PR #1769: URL: https://github.com/apache/nifi-minifi-cpp/pull/1769#discussion_r1579318823 ## CMakeLists.txt: ## @@ -22,7 +22,7 @@ cmake_policy(SET CMP0096 NEW) # policy to preserve the leading zeros in PROJECT_ cmake_policy(SET CMP0065 OLD) # default export policy, required for self-dlopen cmake_policy(SET CMP0135 NEW) # policy to set the timestamps of extracted contents to the time of extraction -project(nifi-minifi-cpp VERSION 0.15.0) +project(nifi-minifi-cpp VERSION 1.0.0) Review Comment: Good catch, I updated the other occurrences as well in 9228ce5a6f3219d2e6b90429a2467c56e5f09051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2344 Update version number to 1.0.0 [nifi-minifi-cpp]
martinzink commented on code in PR #1769: URL: https://github.com/apache/nifi-minifi-cpp/pull/1769#discussion_r1579314596 ## CMakeLists.txt: ## @@ -22,7 +22,7 @@ cmake_policy(SET CMP0096 NEW) # policy to preserve the leading zeros in PROJECT_ cmake_policy(SET CMP0065 OLD) # default export policy, required for self-dlopen cmake_policy(SET CMP0135 NEW) # policy to set the timestamps of extracted contents to the time of extraction -project(nifi-minifi-cpp VERSION 0.15.0) +project(nifi-minifi-cpp VERSION 1.0.0) Review Comment: We should upgrade the version of libcore aswell. https://github.com/apache/nifi-minifi-cpp/blob/7f37f62f5ef86ed922959b25fb0096a2eac51020/libminifi/CMakeLists.txt#L23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINIFICPP-2344 Update version number to 1.0.0 [nifi-minifi-cpp]
lordgamez opened a new pull request, #1769: URL: https://github.com/apache/nifi-minifi-cpp/pull/1769 https://issues.apache.org/jira/browse/MINIFICPP-2344 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
