Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
exceptionfactory closed pull request #8677: NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with boms they can leverage just as we ourselves do. Build for NiFi ends up a bit smaller building on great work that created nifi-shared-bundle layer for common dependencies URL: https://github.com/apache/nifi/pull/8677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
joewitt commented on PR #8677: URL: https://github.com/apache/nifi/pull/8677#issuecomment-2075589942 the check failures seem spurious/unrelated. meanwhile i am rebasing to get these latest commits from main and will push up in about 11 minutes after all checks out locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
joewitt commented on PR #8677: URL: https://github.com/apache/nifi/pull/8677#issuecomment-2075506357 Sounds good. I tried to honor those throughout so not sure why these weren't. But updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
joewitt commented on PR #8677: URL: https://github.com/apache/nifi/pull/8677#issuecomment-2070333872 Squashed all the commits so any further improvements can be seen more easily. Fixed the runtime-manifest-generator output which was getting conflicting log provider implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
joewitt commented on PR #8677: URL: https://github.com/apache/nifi/pull/8677#issuecomment-2069925710 Will rebase for latest commit that landed on main. Will remove dependency:analyze-only from pom. It can be activated on the command line during builds whenever people need. Will restore usage of slf4j-simple where it appears safe to do so. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
joewitt commented on PR #8677: URL: https://github.com/apache/nifi/pull/8677#issuecomment-2068095785 Reduced build size another few MB. Tightened up and cleaned boilerplate in poms. Fixed a few lingering test issues related to nifi-jetty-bundle vs nifi-jetty-nar. Some strange issue with nifi-mock in TestTailFile on Windows where processor var could be null. The system test suite has some issue i still need to run down after the latest round of pom cleanup. Getting a 503 during LoadBalanceIT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
joewitt commented on PR #8677: URL: https://github.com/apache/nifi/pull/8677#issuecomment-2067513494 So far unable to understand why github ci failed the nifi-jetty-nar test. Locally it works fine and the source that creates those nar's does not reference nifi-jetty-bundle or nifi-jetty-nar. What that is old and should be eliminated as a binary in our source tree our current full built works, all tests pass including the ci integration tests, system tests, and nifi runs. So not sure what the deal is there. Will focus on the security related version bumps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
joewitt commented on PR #8677: URL: https://github.com/apache/nifi/pull/8677#issuecomment-2067242412 'nifi-jetty-bundle' was also renamed to 'nifi-jetty-nar' to be consistent with all other nar naming -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
joewitt commented on PR #8677: URL: https://github.com/apache/nifi/pull/8677#issuecomment-2067219879 1. need to fix dependency regressions that now are vuln versions. 2. need to fix errors in https://github.com/apache/nifi/actions/runs/8758685134/job/24040051585?pr=8677. This stems from us using pre-built nars in our test images. We should likely stop this. Note to reviewer: The PR is large but in major part this is true to directory creation/renames. What used to be in nifi-nar-bundles is now in two directories. All contents were moved from nifi-nar-bundles to nifi-extension-bundles All contents in nifi-nar-bundles/nifi-framework-bundle were moved to the top level. This was a key part of separating the build of the core framework from the build of all extensions. There are other minor directory creations for new bom(s) but otherwise the structure is in tact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with
joewitt commented on PR #8677: URL: https://github.com/apache/nifi/pull/8677#issuecomment-2067197169 @exceptionfactory reports the following deps show up now and had been upgraded. they have known vulns Specifically the following: commons-compiler-3.1.9.jar commons-configuration-1.10.jar janino-3.1.9.jar neo4j-1.19.4.jar nimbus-jose-jwt-9.31.jar Addressing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12998 Restructured project/build to drive better enforcement/maintainability of framework vs extensions. Makes it easier for people to build extensions outside our codebase as well with bom
joewitt opened a new pull request, #8677: URL: https://github.com/apache/nifi/pull/8677 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
