[jira] [Commented] (MINIFICPP-378) New threads should detach when battery monitor reduces them

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336413#comment-16336413
 ] 

ASF GitHub Bot commented on MINIFICPP-378:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/247


> New threads should detach when battery monitor reduces them
> ---
>
> Key: MINIFICPP-378
> URL: https://issues.apache.org/jira/browse/MINIFICPP-378
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 0.4.0
>Reporter: marco polo
>Assignee: marco polo
>Priority: Critical
> Fix For: 0.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-378) New threads should detach when battery monitor reduces them

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336412#comment-16336412
 ] 

ASF GitHub Bot commented on MINIFICPP-378:
--

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/247
  
Rebased on master and verified build/tests.  Looks good and will merge.


> New threads should detach when battery monitor reduces them
> ---
>
> Key: MINIFICPP-378
> URL: https://issues.apache.org/jira/browse/MINIFICPP-378
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 0.4.0
>Reporter: marco polo
>Assignee: marco polo
>Priority: Critical
> Fix For: 0.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-378) New threads should detach when battery monitor reduces them

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336320#comment-16336320
 ] 

ASF GitHub Bot commented on MINIFICPP-378:
--

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/247
  
@achristianson that was fixed with #248


> New threads should detach when battery monitor reduces them
> ---
>
> Key: MINIFICPP-378
> URL: https://issues.apache.org/jira/browse/MINIFICPP-378
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 0.4.0
>Reporter: marco polo
>Assignee: marco polo
>Priority: Critical
> Fix For: 0.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-378) New threads should detach when battery monitor reduces them

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336318#comment-16336318
 ] 

ASF GitHub Bot commented on MINIFICPP-378:
--

Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/247
  
Looks like a Travis failure? Not sure if related.


> New threads should detach when battery monitor reduces them
> ---
>
> Key: MINIFICPP-378
> URL: https://issues.apache.org/jira/browse/MINIFICPP-378
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 0.4.0
>Reporter: marco polo
>Assignee: marco polo
>Priority: Critical
> Fix For: 0.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-378) New threads should detach when battery monitor reduces them

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336010#comment-16336010
 ] 

ASF GitHub Bot commented on MINIFICPP-378:
--

Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/247
  
performing additional testing verification...


> New threads should detach when battery monitor reduces them
> ---
>
> Key: MINIFICPP-378
> URL: https://issues.apache.org/jira/browse/MINIFICPP-378
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 0.4.0
>Reporter: marco polo
>Assignee: marco polo
>Priority: Critical
> Fix For: 0.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-378) New threads should detach when battery monitor reduces them

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335903#comment-16335903
 ] 

ASF GitHub Bot commented on MINIFICPP-378:
--

Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/247
  
Currently testing something with this PR. will remove comment when ready to 
merge. 


> New threads should detach when battery monitor reduces them
> ---
>
> Key: MINIFICPP-378
> URL: https://issues.apache.org/jira/browse/MINIFICPP-378
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 0.4.0
>Reporter: marco polo
>Assignee: marco polo
>Priority: Critical
> Fix For: 0.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-378) New threads should detach when battery monitor reduces them

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334618#comment-16334618
 ] 

ASF GitHub Bot commented on MINIFICPP-378:
--

GitHub user phrocker opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/247

MINIFICPP-378: Detach new threads if daemon threads is true

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-378

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/247.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #247


commit 35edf3c3f9f2c8063340bd7d68b485f49c608e37
Author: Marc Parisi 
Date:   2018-01-22T16:45:54Z

MINIFICPP-378: Detach new threads if daemon threads is true




> New threads should detach when battery monitor reduces them
> ---
>
> Key: MINIFICPP-378
> URL: https://issues.apache.org/jira/browse/MINIFICPP-378
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 0.4.0
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
> Fix For: 0.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)