[jira] [Commented] (MINIFICPP-603) Fill gaps in C2 responses for Windows

2018-09-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623633#comment-16623633
 ] 

ASF GitHub Bot commented on MINIFICPP-603:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/402


> Fill gaps in C2 responses for Windows
> -
>
> Key: MINIFICPP-603
> URL: https://issues.apache.org/jira/browse/MINIFICPP-603
> Project: NiFi MiNiFi C++
>  Issue Type: Sub-task
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Major
> Fix For: 0.6.0
>
>
> C2 responses aren't functionally complete in windows. This ticket is meant to 
> fill those gaps. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-603) Fill gaps in C2 responses for Windows

2018-09-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623482#comment-16623482
 ] 

ASF GitHub Bot commented on MINIFICPP-603:
--

Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/402
  
@apiri sorry made a force push. good to go, though


> Fill gaps in C2 responses for Windows
> -
>
> Key: MINIFICPP-603
> URL: https://issues.apache.org/jira/browse/MINIFICPP-603
> Project: NiFi MiNiFi C++
>  Issue Type: Sub-task
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Major
> Fix For: 0.6.0
>
>
> C2 responses aren't functionally complete in windows. This ticket is meant to 
> fill those gaps. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-603) Fill gaps in C2 responses for Windows

2018-09-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623470#comment-16623470
 ] 

ASF GitHub Bot commented on MINIFICPP-603:
--

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/402
  
reviewing


> Fill gaps in C2 responses for Windows
> -
>
> Key: MINIFICPP-603
> URL: https://issues.apache.org/jira/browse/MINIFICPP-603
> Project: NiFi MiNiFi C++
>  Issue Type: Sub-task
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Major
> Fix For: 0.6.0
>
>
> C2 responses aren't functionally complete in windows. This ticket is meant to 
> fill those gaps. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-603) Fill gaps in C2 responses for Windows

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622215#comment-16622215
 ] 

ASF GitHub Bot commented on MINIFICPP-603:
--

GitHub user phrocker opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/402

MINIFICPP-603: Add updates for windows C2 responses

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-603

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/402.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #402


commit 7cb24e00bac8b75337ad92d9d7502efe28761eb3
Author: Marc Parisi 
Date:   2018-09-20T15:13:50Z

MINIFICPP-603: Add updates for windows C2 responses




> Fill gaps in C2 responses for Windows
> -
>
> Key: MINIFICPP-603
> URL: https://issues.apache.org/jira/browse/MINIFICPP-603
> Project: NiFi MiNiFi C++
>  Issue Type: Sub-task
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Major
>
> C2 responses aren't functionally complete in windows. This ticket is meant to 
> fill those gaps. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-603) Fill gaps in C2 responses for Windows

2018-09-20 Thread Mr TheSegfault (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621835#comment-16621835
 ] 

Mr TheSegfault commented on MINIFICPP-603:
--

First step will be to set
{code:java}
if (class_mappings[group].processors_.empty()) {{code}

> Fill gaps in C2 responses for Windows
> -
>
> Key: MINIFICPP-603
> URL: https://issues.apache.org/jira/browse/MINIFICPP-603
> Project: NiFi MiNiFi C++
>  Issue Type: Sub-task
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Major
>
> C2 responses aren't functionally complete in windows. This ticket is meant to 
> fill those gaps. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)