[jira] [Commented] (MINIFICPP-675) Parsed headers should not be searched case insensitively
[ https://issues.apache.org/jira/browse/MINIFICPP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687144#comment-16687144 ] ASF GitHub Bot commented on MINIFICPP-675: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/438 > Parsed headers should not be searched case insensitively > - > > Key: MINIFICPP-675 > URL: https://issues.apache.org/jira/browse/MINIFICPP-675 > Project: NiFi MiNiFi C++ > Issue Type: Documentation >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > Parsed headers should not be searched case insensitively -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-675) Parsed headers should not be searched case insensitively
[
https://issues.apache.org/jira/browse/MINIFICPP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687140#comment-16687140
]
ASF GitHub Bot commented on MINIFICPP-675:
--
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/438#discussion_r233611389
--- Diff: extensions/http-curl/client/HTTPClient.h ---
@@ -147,6 +146,24 @@ class HTTPClient : public BaseHTTPClient, public
core::Connectable {
return header_response_.header_mapping_;
}
+ /**
+ * Locates the header value ignoring case. This is differente than
returning a mapping
--- End diff --
differente -> different
> Parsed headers should not be searched case insensitively
> -
>
> Key: MINIFICPP-675
> URL: https://issues.apache.org/jira/browse/MINIFICPP-675
> Project: NiFi MiNiFi C++
> Issue Type: Documentation
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Major
>
> Parsed headers should not be searched case insensitively
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-675) Parsed headers should not be searched case insensitively
[
https://issues.apache.org/jira/browse/MINIFICPP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687141#comment-16687141
]
ASF GitHub Bot commented on MINIFICPP-675:
--
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/438#discussion_r233613094
--- Diff: extensions/http-curl/client/HTTPClient.h ---
@@ -147,6 +146,24 @@ class HTTPClient : public BaseHTTPClient, public
core::Connectable {
return header_response_.header_mapping_;
}
+ /**
+ * Locates the header value ignoring case. This is differente than
returning a mapping
+ * of all parsed headers.
+ * This function acknowledges that header entries should searched case
insensitively.
--- End diff --
be searched
> Parsed headers should not be searched case insensitively
> -
>
> Key: MINIFICPP-675
> URL: https://issues.apache.org/jira/browse/MINIFICPP-675
> Project: NiFi MiNiFi C++
> Issue Type: Documentation
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Major
>
> Parsed headers should not be searched case insensitively
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-675) Parsed headers should not be searched case insensitively
[ https://issues.apache.org/jira/browse/MINIFICPP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687135#comment-16687135 ] ASF GitHub Bot commented on MINIFICPP-675: -- Github user kevdoran commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/438 Thanks a lot for the quick turn around on this @phrocker! > Parsed headers should not be searched case insensitively > - > > Key: MINIFICPP-675 > URL: https://issues.apache.org/jira/browse/MINIFICPP-675 > Project: NiFi MiNiFi C++ > Issue Type: Documentation >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > > Parsed headers should not be searched case insensitively -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-675) Parsed headers should not be searched case insensitively
[ https://issues.apache.org/jira/browse/MINIFICPP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687089#comment-16687089 ] ASF GitHub Bot commented on MINIFICPP-675: -- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/438 reviewing > Parsed headers should not be searched case insensitively > - > > Key: MINIFICPP-675 > URL: https://issues.apache.org/jira/browse/MINIFICPP-675 > Project: NiFi MiNiFi C++ > Issue Type: Documentation >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > > Parsed headers should not be searched case insensitively -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-675) Parsed headers should not be searched case insensitively
[
https://issues.apache.org/jira/browse/MINIFICPP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687027#comment-16687027
]
ASF GitHub Bot commented on MINIFICPP-675:
--
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/438#discussion_r233590484
--- Diff: extensions/http-curl/tests/HTTPSiteToSiteTests.cpp ---
@@ -123,61 +123,66 @@ struct test_profile {
void run_variance(std::string test_file_location, bool isSecure,
std::string url, const struct test_profile ) {
SiteToSiteTestHarness harness(isSecure);
- SiteToSiteLocationResponder responder(isSecure);
+ SiteToSiteLocationResponder *responder = new
SiteToSiteLocationResponder(isSecure);
--- End diff --
this is a short lived test, we don't care about memory leaks here. and we
don't control stoppage of the web server, so we can avoid issues entirely by
simply adding this to the heap and not concerning ourselves with scope.
> Parsed headers should not be searched case insensitively
> -
>
> Key: MINIFICPP-675
> URL: https://issues.apache.org/jira/browse/MINIFICPP-675
> Project: NiFi MiNiFi C++
> Issue Type: Documentation
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Major
>
> Parsed headers should not be searched case insensitively
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-675) Parsed headers should not be searched case insensitively
[ https://issues.apache.org/jira/browse/MINIFICPP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687022#comment-16687022 ] ASF GitHub Bot commented on MINIFICPP-675: -- GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/438 MINIFICPP-675: Fix issue with hearder evaluation and re-enable test MINIFICPP-668: don't append port if it is not valid Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-675 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/438.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #438 commit ede5ccebee81ef8af51e38828c7afaf7947cf992 Author: Marc Parisi Date: 2018-11-14T19:22:28Z MINIFICPP-675: Fix issue with hearder evaluation and re-enable test MINIFICPP-668: don't append port if it is not valid > Parsed headers should not be searched case insensitively > - > > Key: MINIFICPP-675 > URL: https://issues.apache.org/jira/browse/MINIFICPP-675 > Project: NiFi MiNiFi C++ > Issue Type: Documentation >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > > Parsed headers should not be searched case insensitively -- This message was sent by Atlassian JIRA (v7.6.3#76005)
