[jira] [Commented] (NIFI-2257) Refresh UpdateAttribute Processor advanced shell

2016-07-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385685#comment-15385685
 ] 

ASF GitHub Bot commented on NIFI-2257:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/646


> Refresh UpdateAttribute Processor advanced shell
> 
>
> Key: NIFI-2257
> URL: https://issues.apache.org/jira/browse/NIFI-2257
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Scott Aslan
>Assignee: Scott Aslan
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2257) Refresh UpdateAttribute Processor advanced shell

2016-07-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385681#comment-15385681
 ] 

ASF subversion and git services commented on NIFI-2257:
---

Commit 8f23afde5009d992410e5f63e1f960a39a1ef419 in nifi's branch 
refs/heads/master from [~scottyaslan]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8f23afd ]

[NIFI-2257] [NIFI-2294] refresh updateattribute processor advanced shell and 
fix connection config setting tab scrolling issue
[NIFI-2270] Update splash screen
This closes #646


> Refresh UpdateAttribute Processor advanced shell
> 
>
> Key: NIFI-2257
> URL: https://issues.apache.org/jira/browse/NIFI-2257
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Scott Aslan
>Assignee: Scott Aslan
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2257) Refresh UpdateAttribute Processor advanced shell

2016-07-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385686#comment-15385686
 ] 

ASF GitHub Bot commented on NIFI-2257:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/646
  
Looks great @scottyaslan! This has been merged to master.


> Refresh UpdateAttribute Processor advanced shell
> 
>
> Key: NIFI-2257
> URL: https://issues.apache.org/jira/browse/NIFI-2257
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Scott Aslan
>Assignee: Scott Aslan
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2257) Refresh UpdateAttribute Processor advanced shell

2016-07-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379827#comment-15379827
 ] 

ASF GitHub Bot commented on NIFI-2257:
--

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/646#discussion_r71017973
  
--- Diff: 
nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/webapp/js/application.js
 ---
@@ -1598,9 +1635,9 @@ var ua = {
 // create the editor
 editor = 
$('').addClass(editorClass).appendTo(wrapper).nfeditor({
 languageId: languageId,
-width: (cellNode.width() - 5) + 'px',
+width: '250px',
--- End diff --

I think we want to retain the previous behavior where the editor is the 
width of the entire cell when it's opened.


> Refresh UpdateAttribute Processor advanced shell
> 
>
> Key: NIFI-2257
> URL: https://issues.apache.org/jira/browse/NIFI-2257
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Scott Aslan
>Assignee: Scott Aslan
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2257) Refresh UpdateAttribute Processor advanced shell

2016-07-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379715#comment-15379715
 ] 

ASF GitHub Bot commented on NIFI-2257:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/646
  
Reviewing...


> Refresh UpdateAttribute Processor advanced shell
> 
>
> Key: NIFI-2257
> URL: https://issues.apache.org/jira/browse/NIFI-2257
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Scott Aslan
>Assignee: Scott Aslan
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)