[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430952#comment-15430952
 ] 

ASF subversion and git services commented on NIFI-2411:
---

Commit 58868abad058c143cfcc2cd9b938df579c72e1aa in nifi's branch refs/heads/0.x 
from [~jskora]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=58868ab ]

NIFI-2411: Update to support offsets larger than 2 gigabyte. This closes #903. 
This closes #904.


> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>Assignee: Joe Skora
>  Labels: easyfix
> Fix For: 1.0.0, 0.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}} value for byte offsets 
> limiting it to 2 Gigabytes, switching to {{long}} values will allow it to 
> handle up to 15 Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[Mark Payne (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430953#comment-15430953
 ] 

Mark Payne commented on NIFI-2411:
--

[~jskora] - looks good. +1, Merged to 0.x and master. Thanks!

> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>Assignee: Joe Skora
>  Labels: easyfix
> Fix For: 1.0.0, 0.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}} value for byte offsets 
> limiting it to 2 Gigabytes, switching to {{long}} values will allow it to 
> handle up to 15 Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[Mark Payne (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430926#comment-15430926
 ] 

Mark Payne commented on NIFI-2411:
--

I'll pick it up to review.

> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>Assignee: Joe Skora
>  Labels: easyfix
> Fix For: 1.0.0, 0.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}} value for byte offsets 
> limiting it to 2 Gigabytes, switching to {{long}} values will allow it to 
> handle up to 15 Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430892#comment-15430892
 ] 

Joseph Witt commented on NIFI-2411:
---

removed myself as assignee for review.  anyone else avail please grab it

> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>Assignee: Joe Skora
>  Labels: easyfix
> Fix For: 1.0.0, 0.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}} value for byte offsets 
> limiting it to 2 Gigabytes, switching to {{long}} values will allow it to 
> handle up to 15 Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[Joe Skora (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428857#comment-15428857
 ] 

Joe Skora commented on NIFI-2411:
-

Actually, I tested it with 6GB input files and it worked great, with and 
without the Remove All Content.

It's the way the Mock framework reads the entire file into memory using a 
{{byte[]}} that limits it to 2G (Integer.MAX_VALUE actually).

If you have any thoughts on how to test in a streaming way, I'm glad to look 
into that, but I couldn't find any examples.

> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>Assignee: Joseph Witt
>  Labels: easyfix
> Fix For: 1.0.0, 0.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}} value for byte offsets 
> limiting it to 2 Gigabytes, switching to {{long}} values will allow it to 
> handle up to 15 Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428845#comment-15428845
 ] 

Joseph Witt commented on NIFI-2411:
---

assigned to myself to review.

[~jskora] I'm comfortable with this change not requiring unit test alterations 
frankly.  I surely don't want you making 2GB+ content to test it :-)

> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>Assignee: Joseph Witt
>  Labels: easyfix
> Fix For: 1.0.0, 0.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}} value for byte offsets 
> limiting it to 2 Gigabytes, switching to {{long}} values will allow it to 
> handle up to 15 Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428733#comment-15428733
 ] 

Joseph Witt commented on NIFI-2411:
---

[~jskora] I just assumed - but is this all set for review?  I should have 
waited until it said 'Patch Available' - if it is ready please click 'Submit 
Patch' to signal that.  My bad

> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>Assignee: Joseph Witt
>  Labels: easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}} value for byte offsets 
> limiting it to 2 Gigabytes, switching to {{long}} values will allow it to 
> handle up to 15 Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428731#comment-15428731
 ] 

Joseph Witt commented on NIFI-2411:
---

will review

> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>Assignee: Joe Skora
>  Labels: easyfix
> Fix For: 1.0.0, 0.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}} value for byte offsets 
> limiting it to 2 Gigabytes, switching to {{long}} values will allow it to 
> handle up to 15 Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428727#comment-15428727
 ] 

ASF GitHub Bot commented on NIFI-2411:
--

GitHub user jskora opened a pull request:

https://github.com/apache/nifi/pull/904

NIFI-2411 ModifyBytes should use long instead of int for offsets (1.x)

* Update to support offsets larger than 2 gigabyte.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jskora/nifi NIFI-2411-1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/904.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #904


commit f47d04e5cf3620de833d8c53161214564750dacf
Author: Joe Skora 
Date:   2016-08-19T19:49:11Z

Update to support offsets larger than 2 gigabyte.




> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>Assignee: Joe Skora
>  Labels: easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}} value for byte offsets 
> limiting it to 2 Gigabytes, switching to {{long}} values will allow it to 
> handle up to 15 Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428726#comment-15428726
 ] 

ASF GitHub Bot commented on NIFI-2411:
--

GitHub user jskora opened a pull request:

https://github.com/apache/nifi/pull/903

NIFI-2411 ModifyBytes should use long instead of int for offsets (0.x)

* Update to support offsets larger than 2 gigabyte.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jskora/nifi NIFI-2411-0.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/903.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #903


commit a0e1efd7a3ac1b96dbe63e954dff977084d7c1f9
Author: Joe Skora 
Date:   2016-08-19T19:06:23Z

* Update to support offsets larger than 2 gigabyte.




> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>Assignee: Joe Skora
>  Labels: easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}} value for byte offsets 
> limiting it to 2 Gigabytes, switching to {{long}} values will allow it to 
> handle up to 15 Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395849#comment-15395849
 ] 

Joseph Witt commented on NIFI-2411:
---

thanks Joe.

> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>  Labels: easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}}s for byte offsets limiting 
> it to 2 Gigabytes, switching to {{long}}'s will all it to handle up to 15 
> Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2411) ModifyBytes should use long instead of int for offsets.

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395841#comment-15395841
 ] 

Joseph Witt commented on NIFI-2411:
---

[~jskora] please remove fix versions until there is a patch or PR available and 
someone available to help review or assign it to the next release after the one 
currently being worked on.  It makes the release process very difficult as 
tickets enter into the release we're trying to close down on.

Also the component is Extensions (not core framework).


> ModifyBytes should use long instead of int for offsets.
> ---
>
> Key: NIFI-2411
> URL: https://issues.apache.org/jira/browse/NIFI-2411
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Joe Skora
>  Labels: easyfix
> Fix For: 1.0.0, 0.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> ModifyBytes.onTrigger() uses Java 32 bit {{int}}s for byte offsets limiting 
> it to 2 Gigabytes, switching to {{long}}'s will all it to handle up to 15 
> Exabytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)