[jira] [Commented] (NIFI-2606) FingerprintFactory and default property values

2016-08-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431241#comment-15431241
 ] 

ASF subversion and git services commented on NIFI-2606:
---

Commit 087622eadc5863cfce615dd22dc5584639146e4a in nifi's branch 
refs/heads/master from [~mcgilman]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=087622e ]

NIFI-2606:
- Addressing issue when fingerprinting ReportingTasks and ControllerServices 
properties with default values.
- Ensuring the flow is saved when templates are created and imported.
- Ensuring default values are included in templates.
- Fixing unit tests.
This closes #908.


> FingerprintFactory and default property values
> --
>
> Key: NIFI-2606
> URL: https://issues.apache.org/jira/browse/NIFI-2606
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Matt Gilman
>Assignee: Matt Gilman
> Fix For: 1.0.0
>
>
> When a node joins a cluster, it checks the proposed flow (of the cluster) 
> against it's local flow. The proposed flow will include default property 
> values if a property is not explicitly set. This is accounted for when 
> comparing a Processor but is not for Controller Services and Reporting Tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2606) FingerprintFactory and default property values

2016-08-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431244#comment-15431244
 ] 

ASF GitHub Bot commented on NIFI-2606:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/908


> FingerprintFactory and default property values
> --
>
> Key: NIFI-2606
> URL: https://issues.apache.org/jira/browse/NIFI-2606
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Matt Gilman
>Assignee: Matt Gilman
> Fix For: 1.0.0
>
>
> When a node joins a cluster, it checks the proposed flow (of the cluster) 
> against it's local flow. The proposed flow will include default property 
> values if a property is not explicitly set. This is accounted for when 
> comparing a Processor but is not for Controller Services and Reporting Tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2606) FingerprintFactory and default property values

2016-08-22 Thread Mark Payne (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431086#comment-15431086
 ] 

Mark Payne commented on NIFI-2606:
--

Reviewing...

> FingerprintFactory and default property values
> --
>
> Key: NIFI-2606
> URL: https://issues.apache.org/jira/browse/NIFI-2606
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Matt Gilman
>Assignee: Matt Gilman
> Fix For: 1.0.0
>
>
> When a node joins a cluster, it checks the proposed flow (of the cluster) 
> against it's local flow. The proposed flow will include default property 
> values if a property is not explicitly set. This is accounted for when 
> comparing a Processor but is not for Controller Services and Reporting Tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2606) FingerprintFactory and default property values

2016-08-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431054#comment-15431054
 ] 

ASF GitHub Bot commented on NIFI-2606:
--

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/908

Addressing issue when fingerprinting flows with default values

NIFI-2606:
- Addressing issue when fingerprinting ReportingTasks and 
ControllerServices properties with default values.
- Ensuring the flow is saved when templates are created and imported.
- Ensuring default values are included in templates.
- Fixing unit tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-2606

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/908.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #908


commit b753b86125531560f21f3332182be804cf940928
Author: Matt Gilman 
Date:   2016-08-22T15:48:22Z

NIFI-2606:
- Addressing issue when fingerprinting ReportingTasks and 
ControllerServices properties with default values.
- Ensuring the flow is saved when templates are created and imported.
- Ensuring default values are included in templates.
- Fixing unit tests.




> FingerprintFactory and default property values
> --
>
> Key: NIFI-2606
> URL: https://issues.apache.org/jira/browse/NIFI-2606
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Matt Gilman
>Assignee: Matt Gilman
> Fix For: 1.0.0
>
>
> When a node joins a cluster, it checks the proposed flow (of the cluster) 
> against it's local flow. The proposed flow will include default property 
> values if a property is not explicitly set. This is accounted for when 
> comparing a Processor but is not for Controller Services and Reporting Tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)