[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15657983#comment-15657983
 ] 

ASF GitHub Bot commented on NIFI-2898:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1191


> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15657984#comment-15657984
 ] 

ASF GitHub Bot commented on NIFI-2898:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1191
  
Looks good @scottyaslan! This has been merged to master.


> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15657982#comment-15657982
 ] 

ASF subversion and git services commented on NIFI-2898:
---

Commit 52cde9ad1397e7785fbe12379cf2b50c3b275722 in nifi's branch 
refs/heads/master from [~scottyaslan]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=52cde9a ]

[NIFI-2898] restore ellipsis for processor type, controller servies type, and 
reporting task type descriptions. This closes #1191


> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656988#comment-15656988
 ] 

ASF GitHub Bot commented on NIFI-2898:
--

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/1191
  
Thanks for the info @scottyaslan – I understand the issue regarding the 
spacing/height so addressing in a follow on Jira is best. 

I did just check out the latest and it looks good! 


> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656053#comment-15656053
 ] 

ASF GitHub Bot commented on NIFI-2898:
--

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/1191
  
@moranr @mcgilman I have updated this PR to also include a 'fix' to the 
ellipsis plugin for the view state description.

@moranr I think you were seeing a caching issue with the scrollable 
style...anyway, it should be fixed now with the latest update to this PR. Also 
I was able to apply the styles you suggested in the Jira. Be aware, however, 
there is an issue with the spacing you outlined in the Jira. The issue is that 
the ellipsis plugin requires the width and height of the element be set in 
'px'. With the responsive nature of the dialogs I do not believe we can support 
these descriptions as responsive divs that would be necessary to fulfill said 
spacing (i.e. to support a responsive description area div we would need to 
apply position:absolute). This will require a much larger effort and as the 
original ask for NIFI-2898 was to restore the 0.x ellipsis functionality I 
think we could consider the spacing you outlined as part of a follow on Jira 
that will support the scrollable description areas (as discussed in 
https://issues.apache.org/jira/browse/NIFI-2898). Please let me know what you 
think...


> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654027#comment-15654027
 ] 

ASF GitHub Bot commented on NIFI-2898:
--

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/1191
  
@mcgilman  I think it makes sense to use the ellipsis for view state too.

@scottyaslan I'm still seeing the scrollable class applied on the Add 
Processor description as well, so I can both scroll _and_ hover to see the full 
description.

Also, can we apply the the styling that I outlined in my earlier jira 
comment to all these areas? This way both behavior and design will be 
consistent.


> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652243#comment-15652243
 ] 

ASF GitHub Bot commented on NIFI-2898:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1191
  
I have verified that the ellipsis have been restored to the descriptions of 
the new Processor, Controller Service, and Reporting Task table. However, it 
appears as though we are still using a scrollable area for the View State 
dialog. Should we make these consistent?


> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652117#comment-15652117
 ] 

ASF GitHub Bot commented on NIFI-2898:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1191
  
Reviewing...


> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651493#comment-15651493
 ] 

ASF GitHub Bot commented on NIFI-2898:
--

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi/pull/1191

[NIFI-2898] restore ellipsis for processor type, controller servies t…

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

…ype, and reporting task type descriptions

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi NIFI-2898

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1191


commit 32f461e0ef8e9c2a0dedd1f4f07b417ee47d28ce
Author: Scott Aslan 
Date:   2016-11-09T17:16:16Z

[NIFI-2898] restore ellipsis for processor type, controller servies type, 
and reporting task type descriptions




> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[Matt Gilman (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592379#comment-15592379
 ] 

Matt Gilman commented on NIFI-2898:
---

[~scottyaslan] [~rmoran] The two area's in question is the processor dialog and 
the view state dialog. Both of the descriptions rendered here are meant to be a 
short synopsis. The multiline ellipsis was introduced there in case the text 
ran over.

I think adjusting the layout and converting to a scrollable approach may be a 
great long-term approach. As Scott pointed out this will snowball into other 
changes as we move to remove the ellipsis plugin (which is only necessary for 
supporting multiline ellipsis). In the short term, I believe reverting back to 
the multiline ellipsis is a good idea so we can consider the ramifications of 
the scrollable approach.

> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[Rob Moran (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591793#comment-15591793
 ] 

Rob Moran commented on NIFI-2898:
-

Understood re: adding the the scrollable condition on tables. It was only a 
suggestion and a separate matter we can revisit if necessary.

+1 on the simple solution you propose (i.e., bring back the ellipsis and 
removing the fixed height restriction) because as you said this would be a 
bigger effort due to other impacted areas. I am still a fan of the scrolling on 
long descriptions because it is frustrating to have to read a partial, but 
still long block of text, then hover to receive the full block and find your 
place again to continue reading. We can continue to explore other options as 
they come up.

> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[Scott Aslan (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589624#comment-15589624
 ] 

Scott Aslan commented on NIFI-2898:
---

[~rmoran] I can look at adding the scrollable type to the 
#processor-types-table​ but I think that if we were to add that we would also 
need to add this conditional style to all slickgrid tables and I would think we 
would need another ticket for this.

> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[Rob Moran (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589545#comment-15589545
 ] 

Rob Moran commented on NIFI-2898:
-

I also notice that a similar pattern is used in the Component State dialog 
(e.g., select 'View state' action from the context menu of the TailFile 
processor). It would be nice to again use the available height for the 
description before the table starts and use the same styling for the label, 
component name, and its description. I have created NIFI-2921 to capture 
details and linked it to this issue.

> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[Rob Moran (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589495#comment-15589495
 ] 

Rob Moran commented on NIFI-2898:
-


I think the move to a scrolling pattern was a good choice. I do think some more 
improvements could be made to the way space is utilized, along with a few style 
changes.

I attached a screenshot  – *processor-description-scrolling.png* – that I did 
using browser dev tool, then added some annotation on top since I could not get 
it exactly as intended.

As I describe in the attached file, it would be nice to use the remaining 
height to display as much of the description as possible. To add, it would be 
nice if that available height was fluid as the height of the dialog changes. 
This way the description would always end 20px above the dialog buttons.

As mentioned there were a few style changes made:

For _#processor-type-name-title_ changed/added​{code}​padding: 20px 0 4px 0; 
font-size: 12px;​{code}​
For ​_​#processor-type-name​_​ changed/added​{code}​color: #775351; font-size: 
13px; font-weight: 500;​{code}​
For ​_​#processor-type-description​_​ changed/added{code}​font-size: 13px; 
line-height: 17px;​{code}​

​We could also add the 'scrollable' class to the _#processor-types-table​_ to 
be consistent with how scrollable content is displayed.

> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583463#comment-15583463
 ] 

ASF GitHub Bot commented on NIFI-2898:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/1134
  
+1. Checked change with Firefox and Chrome, merging...


> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.2.0
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583472#comment-15583472
 ] 

ASF GitHub Bot commented on NIFI-2898:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1134


> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.2.0
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583471#comment-15583471
 ] 

ASF subversion and git services commented on NIFI-2898:
---

Commit 9fb3039416d05ea1e76e530c29527d466927e1d1 in nifi's branch 
refs/heads/master from [~scottyaslan]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9fb3039 ]

[NIFI-2898] Add Processor dialog processor descriptions now scrollable

This closes #1134.


> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.2.0
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573157#comment-15573157
 ] 

ASF GitHub Bot commented on NIFI-2898:
--

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi/pull/1134

[NIFI-2898] Add Processor dialog processor descriptions now scrollable

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi NIFI-2898

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1134


commit 33405e0ece7ed0b9006d074eea1d4b924a2439f3
Author: Scott Aslan 
Date:   2016-10-13T20:55:17Z

[NIFI-2898] Add Processor dialog processor descriptions now scrollable




> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.2.0
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)