[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[Joseph Percivall (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651486#comment-15651486
 ] 

Joseph Percivall commented on NIFI-2905:


This should actually be closed since the issue has been resolved (fixed 
here[1]). I'll close

[1] https://issues.apache.org/jira/browse/NIFI-2936

> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
> Fix For: 1.1.0
>
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651474#comment-15651474
 ] 

Joseph Witt commented on NIFI-2905:
---

[~ijokarumawak] [~JPercivall] is this still a 1.1 release target or should we 
remove the fix version for now?

> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
> Fix For: 1.1.0
>
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[Joseph Percivall (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609670#comment-15609670
 ] 

Joseph Percivall commented on NIFI-2905:


Looks like this breaks the build on CentOS: 
http://stackoverflow.com/questions/40272015/nifi-build-errors

> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
> Fix For: 1.1.0
>
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[Koji Kawamura (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603869#comment-15603869
 ] 

Koji Kawamura commented on NIFI-2905:
-

[~JPercivall] Thanks for catching that. I took a look on that and find there is 
an async call to execute process in another thread and somehow the log was not 
written, before the main thread to check the log count. I'll investigate more 
and will send a separate PR to address this.

> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
> Fix For: 1.1.0
>
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[Aldrin Piri (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603743#comment-15603743
 ] 

Aldrin Piri commented on NIFI-2905:
---

I created a ticket this morning, NIFI-2936 to address.  Will link to this issue 
and you can work it from whichever side makes more sense.

> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
> Fix For: 1.1.0
>
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603252#comment-15603252
 ] 

ASF GitHub Bot commented on NIFI-2905:
--

Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1143
  
@ijokarumawak @alopresto @pvillard31 I am seeing errors in travis related 
to this PR[1]. I am going to re-open the ticket in order to investigate

[1] https://s3.amazonaws.com/archive.travis-ci.org/jobs/170218968/log.txt


> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
> Fix For: 1.1.0
>
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586949#comment-15586949
 ] 

ASF GitHub Bot commented on NIFI-2905:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1143


> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586947#comment-15586947
 ] 

ASF subversion and git services commented on NIFI-2905:
---

Commit 27dba60f27579ca9f33aa1afbf4bb46182d57df4 in nifi's branch 
refs/heads/master from [~ijokarumawak]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=27dba60 ]

NIFI-2905: Log error stream of ExecuteProcess cmd

ExecuteProcess ignores error stream when Redirect Error Stream is
false, this commit let it to be logged instead so that user can see it on
bulletin.

This closes #1143.

Signed-off-by: Andy LoPresto 


> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586943#comment-15586943
 ] 

ASF GitHub Bot commented on NIFI-2905:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1143
  
Built with `contrib-check` and verified all tests pass. I started the 
application, and used an `ExecuteProcess` processor with command `cd` and 
arguments `non-existent-dir`. With `Redirect Error Stream` set to **false** 
(default), the errors appeared as bulletins. With `Redirect Error Stream` set 
to **true**, no bulletins were raised, and the error message was found in the 
resulting flowfile contents. 

+1, merging. 


> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586879#comment-15586879
 ] 

ASF GitHub Bot commented on NIFI-2905:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1143
  
Reviewing...


> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584184#comment-15584184
 ] 

ASF GitHub Bot commented on NIFI-2905:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1143
  
@pvillard31 Thanks for catching that, I was able to reproduce that the test 
fails with mvn command. Investigating how to address it. I'll send an updated 
PR once it's get fixed. Thank you!


> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583405#comment-15583405
 ] 

ASF GitHub Bot commented on NIFI-2905:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/1143
  
Hey @ijokarumawak 
One of the unit tests is failing on my side:
Failed tests:
  TestExecuteProcess.testNotRedirectErrorStream:226 If redirect error 
stream is false, the output should be logged as a warning so that user can 
notice on bulletin. expected:<1> but was:<0>

Note: the test is failing while running a maven build, although everything 
is fine in my IDE.



> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581582#comment-15581582
 ] 

ASF GitHub Bot commented on NIFI-2905:
--

GitHub user ijokarumawak opened a pull request:

https://github.com/apache/nifi/pull/1143

NIFI-2905: Log error stream of ExecuteProcess cmd

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijokarumawak/nifi nifi-2905

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1143


commit 8edf84ab5384e85dfef8ac29d8c76ac55f052e75
Author: Koji Kawamura 
Date:   2016-10-17T08:07:32Z

NIFI-2905: Log error stream of ExecuteProcess cmd

ExecuteProcess ignores error stream when Redirect Error Stream is
false, this commit let it to be logged instead so that user can see it on
bulletin.




> ExecuteProcess should log error stream instead of ignoring it
> -
>
> Key: NIFI-2905
> URL: https://issues.apache.org/jira/browse/NIFI-2905
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> When a command executed by ExecuteProcess processor didn't work properly and 
> emitted error messages to error stream, but the processor's configured with 
> 'Redirect Error Stream' as 'false' (default), then the error messages are 
> ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user 
> can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)