[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633823#comment-15633823
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user brosander commented on the issue:

https://github.com/apache/nifi/pull/1180
  
+1, merged


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633821#comment-15633821
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user brosander commented on the issue:

https://github.com/apache/nifi/pull/1180
  
+1, merging


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633813#comment-15633813
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1180


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-11-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633811#comment-15633811
 ] 

ASF subversion and git services commented on NIFI-2928:
---

Commit 0841f14c18eb3798ebc798406109bd3f9bdb6643 in nifi's branch 
refs/heads/master from [~mattyb149]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=0841f14 ]

NIFI-2928: Fixed checkstyle violation in FetchFile

This closes #1180

Signed-off-by: Bryan Rosander 


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633721#comment-15633721
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

GitHub user mattyb149 opened a pull request:

https://github.com/apache/nifi/pull/1180

NIFI-2928: Fixed checkstyle violation in FetchFile

Missed this during review :(


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mattyb149/nifi NIFI-2928

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1180






> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1566#comment-1566
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1160


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-11-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1564#comment-1564
 ] 

ASF subversion and git services commented on NIFI-2928:
---

Commit ed035f85e38f7c9efe6ac84c8f13c9a455f7014c in nifi's branch 
refs/heads/master from [~ozhurakousky]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ed035f8 ]

NIFI-2928 added support to validate accessibility of the file system

NIFI-2928 polishing

This closes #1160


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-11-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1563#comment-1563
 ] 

ASF subversion and git services commented on NIFI-2928:
---

Commit ed035f85e38f7c9efe6ac84c8f13c9a455f7014c in nifi's branch 
refs/heads/master from [~ozhurakousky]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ed035f8 ]

NIFI-2928 added support to validate accessibility of the file system

NIFI-2928 polishing

This closes #1160


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633294#comment-15633294
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user mattyb149 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1160#discussion_r86382090
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFetchFile.java
 ---
@@ -48,6 +48,19 @@ public void prepDestDirectory() throws IOException {
 }
 
 @Test
+public void notFound() throws IOException {
+final File sourceFile = new File("notFound");
--- End diff --

Rgr, +1 LGTM merging to master


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633278#comment-15633278
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1160#discussion_r86380802
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFetchFile.java
 ---
@@ -48,6 +48,19 @@ public void prepDestDirectory() throws IOException {
 }
 
 @Test
+public void notFound() throws IOException {
+final File sourceFile = new File("notFound");
--- End diff --

That is correct. We can only test it in some specially set integration 
environment where you may have a remote share that is known to the OS but 
temporarily unreachable. That is where the new code becomes relevant.


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-10-25 Thread Oleg Zhurakousky (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605401#comment-15605401
 ] 

Oleg Zhurakousky commented on NIFI-2928:


I see. . .. Fair point albeit very confusing with _exists(..) and notExists(..)_
Will take care. 

> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-10-24 Thread Oleg Zhurakousky (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602168#comment-15602168
 ] 

Oleg Zhurakousky commented on NIFI-2928:


[~ch...@mcdermott.net] after reading javadoc for _checkAccess()_ I am now 
starting to think that it is good the way it is now.
Basically here is what it says:
{code}
* Checks the existence, and optionally the accessibility, of a file.
. . .
*  This method checks the existence of a file and that this Java virtual
* machine has appropriate privileges that would allow it access the file
* according to all of access modes specified in the {@code modes} parameter
* as follows:
. . .
{code}
Basically while one may argue that this method is a bit more sophisticated then 
what we have now, in reality there is no way to distinguish between 
non-existing file or non-accessible file since it encapsulates both/all.

Do you agree? 

> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

2016-10-21 Thread Oleg Zhurakousky (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595065#comment-15595065
 ] 

Oleg Zhurakousky commented on NIFI-2928:


I've just fixed a very similar issue with GetFile (NIFI-2919), so I will target 
this for 1.1 since the fix for this one is very similar.

> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)