[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676241#comment-15676241
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1238
  
Example:

```
# Commented login-identity-providers.xml file by default

hw12203:...assembly/target/nifi-toolkit-1.1.0-SNAPSHOT-bin/nifi-toolkit-1.1.0-SNAPSHOT
 (master) alopresto
 62s @ 01:05:01 $ ./bin/encrypt-config.sh -b 
../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/bootstrap.conf
 -l 
../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/login-identity-providers.xml
 -k 0123456789ABCDEFFEDCBA98765432100123456789ABCDEFFEDCBA9876543210
2016/11/18 01:05:11 WARN [main] 
org.apache.nifi.properties.ConfigEncryptionTool: The source 
login-identity-providers.xml and destination login-identity-providers.xml are 
identical 
[../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/login-identity-providers.xml]
 so the original will be overwritten
2016/11/18 01:05:11 INFO [main] 
org.apache.nifi.properties.ConfigEncryptionTool: Loaded LoginIdentityProviders 
content (107 lines)
2016/11/18 01:05:11 ERROR [main] 
org.apache.nifi.properties.ConfigEncryptionTool: No provider element with class 
org.apache.nifi.ldap.LdapProvider found in XML content; the file could be empty 
or the element may be missing or commented out

# Uncomment the ldap-provider element

hw12203:...assembly/target/nifi-toolkit-1.1.0-SNAPSHOT-bin/nifi-toolkit-1.1.0-SNAPSHOT
 (master) alopresto
 10s @ 01:05:12 $ subl 
../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/login-identity-providers.xml

# Run the encrypt command against an empty ldap-provider element

hw12203:...assembly/target/nifi-toolkit-1.1.0-SNAPSHOT-bin/nifi-toolkit-1.1.0-SNAPSHOT
 (master) alopresto
 26s @ 01:05:39 $ ./bin/encrypt-config.sh -b 
../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/bootstrap.conf
 -l 
../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/login-identity-providers.xml
 -k 0123456789ABCDEFFEDCBA98765432100123456789ABCDEFFEDCBA9876543210
2016/11/18 01:06:02 WARN [main] 
org.apache.nifi.properties.ConfigEncryptionTool: The source 
login-identity-providers.xml and destination login-identity-providers.xml are 
identical 
[../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/login-identity-providers.xml]
 so the original will be overwritten
2016/11/18 01:06:02 INFO [main] 
org.apache.nifi.properties.ConfigEncryptionTool: Loaded LoginIdentityProviders 
content (105 lines)

# No populated passwords

hw12203:...assembly/target/nifi-toolkit-1.1.0-SNAPSHOT-bin/nifi-toolkit-1.1.0-SNAPSHOT
 (master) alopresto
 24s @ 01:06:03 $ more 
../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/login-identity-providers.xml
 | grep Password
'Manager Password' - The password of the manager that is used to 
bind to the LDAP server to
'TLS - Keystore Password' - Password for the Keystore that is used 
when connecting to LDAP
'TLS - Truststore Password' - Password for the Truststore that is 
used when connecting to
  
  
  

# Populate passwords

hw12203:...assembly/target/nifi-toolkit-1.1.0-SNAPSHOT-bin/nifi-toolkit-1.1.0-SNAPSHOT
 (master) alopresto
 21s @ 01:06:24 $ subl 
../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/login-identity-providers.xml

# View the populated passwords

hw12203:...assembly/target/nifi-toolkit-1.1.0-SNAPSHOT-bin/nifi-toolkit-1.1.0-SNAPSHOT
 (master) alopresto
 7s @ 01:06:32 $ more 
../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/login-identity-providers.xml
 | grep Password
'Manager Password' - The password of the manager that is used to 
bind to the LDAP server to
'TLS - Keystore Password' - Password for the Keystore that is used 
when connecting to LDAP
'TLS - Truststore Password' - Password for the Truststore that is 
used when connecting to
  thisIsABadPassword
  thisIsABadPassword
  thisIsABadPassword

# Run the tool against the populated, uncommented ldap-provider

hw12203:...assembly/target/nifi-toolkit-1.1.0-SNAPSHOT-bin/nifi-toolkit-1.1.0-SNAPSHOT
 (master) alopresto
 46s @ 01:07:19 $ ./bin/encrypt-config.sh -b 
../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/bootstrap.conf
 -l 
../../../../../nifi-assembly/target/nifi-1.1.0-SNAPSHOT-bin/nifi-1.1.0-SNAPSHOT/conf/login-identity-providers.xml
 -k

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-18 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676237#comment-15676237
 ] 

ASF subversion and git services commented on NIFI-3051:
---

Commit 8568d40cd80ad12a258fbee498b733b78428a608 in nifi's branch 
refs/heads/master from [~alopresto]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8568d40 ]

NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.

Cleaned up commented pom.xml contents. (+4 squashed commits)
Squashed commits:
[725860b] NIFI-3051 Switched CET test logging dependency from logback to log4j 
as Zookeeper migration has an explicit dependency on log4j as the logging 
provider and the two libraries were causing classpath collisions. Now the tests 
run in both Maven and Intellij, the tools all build successfully, and the tools 
all run (TLS Toolkit, CET, and ZK) without logging provider warnings and print 
the expected output to the console.
[0e604c7] NIFI-3051 Changed provider element selection in serialize method to 
be by class (org.apache.nifi.ldap.LdapProvider) rather than identifier in case 
it has been modified.
Added unit tests.
[300a23d] NIFI-3051 Changed provider element selection to be by class 
(org.apache.nifi.ldap.LdapProvider) rather than identifier in case it has been 
modified.
Added unit tests.
[a0cdd40] NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.
Updated and added unit tests. (+1 squashed commit)
Squashed commits:
[b187202] NIFI-3051 - checked in test demonstrating failure to serialize 
commented ldap-provider section.

This closes #1238.

Signed-off-by: Andy LoPresto 


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-18 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676238#comment-15676238
 ] 

ASF subversion and git services commented on NIFI-3051:
---

Commit 8568d40cd80ad12a258fbee498b733b78428a608 in nifi's branch 
refs/heads/master from [~alopresto]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8568d40 ]

NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.

Cleaned up commented pom.xml contents. (+4 squashed commits)
Squashed commits:
[725860b] NIFI-3051 Switched CET test logging dependency from logback to log4j 
as Zookeeper migration has an explicit dependency on log4j as the logging 
provider and the two libraries were causing classpath collisions. Now the tests 
run in both Maven and Intellij, the tools all build successfully, and the tools 
all run (TLS Toolkit, CET, and ZK) without logging provider warnings and print 
the expected output to the console.
[0e604c7] NIFI-3051 Changed provider element selection in serialize method to 
be by class (org.apache.nifi.ldap.LdapProvider) rather than identifier in case 
it has been modified.
Added unit tests.
[300a23d] NIFI-3051 Changed provider element selection to be by class 
(org.apache.nifi.ldap.LdapProvider) rather than identifier in case it has been 
modified.
Added unit tests.
[a0cdd40] NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.
Updated and added unit tests. (+1 squashed commit)
Squashed commits:
[b187202] NIFI-3051 - checked in test demonstrating failure to serialize 
commented ldap-provider section.

This closes #1238.

Signed-off-by: Andy LoPresto 


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676239#comment-15676239
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1238


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-18 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676235#comment-15676235
 ] 

ASF subversion and git services commented on NIFI-3051:
---

Commit 8568d40cd80ad12a258fbee498b733b78428a608 in nifi's branch 
refs/heads/master from [~alopresto]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8568d40 ]

NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.

Cleaned up commented pom.xml contents. (+4 squashed commits)
Squashed commits:
[725860b] NIFI-3051 Switched CET test logging dependency from logback to log4j 
as Zookeeper migration has an explicit dependency on log4j as the logging 
provider and the two libraries were causing classpath collisions. Now the tests 
run in both Maven and Intellij, the tools all build successfully, and the tools 
all run (TLS Toolkit, CET, and ZK) without logging provider warnings and print 
the expected output to the console.
[0e604c7] NIFI-3051 Changed provider element selection in serialize method to 
be by class (org.apache.nifi.ldap.LdapProvider) rather than identifier in case 
it has been modified.
Added unit tests.
[300a23d] NIFI-3051 Changed provider element selection to be by class 
(org.apache.nifi.ldap.LdapProvider) rather than identifier in case it has been 
modified.
Added unit tests.
[a0cdd40] NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.
Updated and added unit tests. (+1 squashed commit)
Squashed commits:
[b187202] NIFI-3051 - checked in test demonstrating failure to serialize 
commented ldap-provider section.

This closes #1238.

Signed-off-by: Andy LoPresto 


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-18 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676236#comment-15676236
 ] 

ASF subversion and git services commented on NIFI-3051:
---

Commit 8568d40cd80ad12a258fbee498b733b78428a608 in nifi's branch 
refs/heads/master from [~alopresto]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8568d40 ]

NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.

Cleaned up commented pom.xml contents. (+4 squashed commits)
Squashed commits:
[725860b] NIFI-3051 Switched CET test logging dependency from logback to log4j 
as Zookeeper migration has an explicit dependency on log4j as the logging 
provider and the two libraries were causing classpath collisions. Now the tests 
run in both Maven and Intellij, the tools all build successfully, and the tools 
all run (TLS Toolkit, CET, and ZK) without logging provider warnings and print 
the expected output to the console.
[0e604c7] NIFI-3051 Changed provider element selection in serialize method to 
be by class (org.apache.nifi.ldap.LdapProvider) rather than identifier in case 
it has been modified.
Added unit tests.
[300a23d] NIFI-3051 Changed provider element selection to be by class 
(org.apache.nifi.ldap.LdapProvider) rather than identifier in case it has been 
modified.
Added unit tests.
[a0cdd40] NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.
Updated and added unit tests. (+1 squashed commit)
Squashed commits:
[b187202] NIFI-3051 - checked in test demonstrating failure to serialize 
commented ldap-provider section.

This closes #1238.

Signed-off-by: Andy LoPresto 


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-18 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676233#comment-15676233
 ] 

ASF subversion and git services commented on NIFI-3051:
---

Commit 8568d40cd80ad12a258fbee498b733b78428a608 in nifi's branch 
refs/heads/master from [~alopresto]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8568d40 ]

NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.

Cleaned up commented pom.xml contents. (+4 squashed commits)
Squashed commits:
[725860b] NIFI-3051 Switched CET test logging dependency from logback to log4j 
as Zookeeper migration has an explicit dependency on log4j as the logging 
provider and the two libraries were causing classpath collisions. Now the tests 
run in both Maven and Intellij, the tools all build successfully, and the tools 
all run (TLS Toolkit, CET, and ZK) without logging provider warnings and print 
the expected output to the console.
[0e604c7] NIFI-3051 Changed provider element selection in serialize method to 
be by class (org.apache.nifi.ldap.LdapProvider) rather than identifier in case 
it has been modified.
Added unit tests.
[300a23d] NIFI-3051 Changed provider element selection to be by class 
(org.apache.nifi.ldap.LdapProvider) rather than identifier in case it has been 
modified.
Added unit tests.
[a0cdd40] NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.
Updated and added unit tests. (+1 squashed commit)
Squashed commits:
[b187202] NIFI-3051 - checked in test demonstrating failure to serialize 
commented ldap-provider section.

This closes #1238.

Signed-off-by: Andy LoPresto 


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-18 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676234#comment-15676234
 ] 

ASF subversion and git services commented on NIFI-3051:
---

Commit 8568d40cd80ad12a258fbee498b733b78428a608 in nifi's branch 
refs/heads/master from [~alopresto]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8568d40 ]

NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.

Cleaned up commented pom.xml contents. (+4 squashed commits)
Squashed commits:
[725860b] NIFI-3051 Switched CET test logging dependency from logback to log4j 
as Zookeeper migration has an explicit dependency on log4j as the logging 
provider and the two libraries were causing classpath collisions. Now the tests 
run in both Maven and Intellij, the tools all build successfully, and the tools 
all run (TLS Toolkit, CET, and ZK) without logging provider warnings and print 
the expected output to the console.
[0e604c7] NIFI-3051 Changed provider element selection in serialize method to 
be by class (org.apache.nifi.ldap.LdapProvider) rather than identifier in case 
it has been modified.
Added unit tests.
[300a23d] NIFI-3051 Changed provider element selection to be by class 
(org.apache.nifi.ldap.LdapProvider) rather than identifier in case it has been 
modified.
Added unit tests.
[a0cdd40] NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.
Updated and added unit tests. (+1 squashed commit)
Squashed commits:
[b187202] NIFI-3051 - checked in test demonstrating failure to serialize 
commented ldap-provider section.

This closes #1238.

Signed-off-by: Andy LoPresto 


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675860#comment-15675860
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user YolandaMDavis commented on the issue:

https://github.com/apache/nifi/pull/1238
  
@alopresto was able to run tests both in IDE and Maven and reconfirmed test 
scenarios worked as expected.

+1

Ready for merge.


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675390#comment-15675390
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1238
  
I talked to @YolandaMDavis -- she will review and give a final yes/no and 
then I can merge. 


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675318#comment-15675318
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1238
  
@jtstorck and I resolved the logging issue. Because the Zookeeper migrator 
has an explicit dependency on `log4j` instead of `slf4j`, `log4j` was competing 
with the existing `logback` implementation that was already present in the 
`lib/`. I switched the `TestAppender` implementation in 
`ConfigEncryptionToolTest` to extend `log4j`'s `AppenderSkeleton` instead of 
`logback`'s `AppenderBase` and updated a couple tests. Now the 
tests run properly in both an IDE and Maven, and all the tools (TLS, ZK, and 
EC) run properly (print expected output to console and do not warn about 
multiple available logging implementations). 


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674862#comment-15674862
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1238
  
I rebased against master and fixed the issue with `serialize...` I 
described above. For posterity, the un-rebased branch with the same fixes is 
still available [in my 
repo](https://github.com/alopresto/nifi/tree/NIFI-3051-before-rebase). 


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674740#comment-15674740
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1238
  
@YolandaMDavis please wait -- I realized I did not change the 
`serializeLoginIdentityProvidersAndPreserveFormat()` to use the new `class` 
criteria instead of the `identifier` as it was before. Need to provide a fix 
and test for that. 

Also would like to get a fix for the logger stuff that was introduced in 
1237 -- Maven build is fine but the tests that depend on asserting against 
`TestAppender` fail in IntelliJ for multiple developers. Removing the 
`` element for `ch.qos.logback:logback-classic` in 
`org.apache.nifi:nifi-properties-loader` in 
`nifi-toolkit-encrypt-config/pom.xml` resolves the test errors, but the built 
toolkit has logging issues because of conflicting logging libraries in the 
path. 


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674728#comment-15674728
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user YolandaMDavis commented on the issue:

https://github.com/apache/nifi/pull/1238
  
@alopresto thanks for the update.  Was able to retest with the following 
scenarios:

encryption with fully commented file (as in the original template without 
edits)
encryption with one provider (using an Ldap Provider class) commented out, 
another provider available
encryption with ldap provider available

All scenarios work as expected.

+1

Will merge shortly into master


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674514#comment-15674514
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1238
  
As @YolandaMDavis pointed out above, this branch came from a branch that 
was demoing the failed test, so it was not rebased against master. Due to the 
logging changes in [PR 1237](https://github.com/apache/nifi/pull/1237) there 
are differences in the logging infrastructure that need to be resolved. 


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674507#comment-15674507
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1238
  
Copied from Jira discussion:

> I am willing to look for 
`org.apache.nifi.ldap.LdapProvider` rather than a specific 
identifier, but much farther down that path would lead to anarchy – people have 
to define the XML content to validly define an LDAP provider, not just 
arbitrary passwords.


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread Yolanda M. Davis (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674450#comment-15674450
 ] 

Yolanda M. Davis commented on NIFI-3051:


I think that is fair given that there will be flexibility on the identifier.  
Thanks Andy.

> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread Andy LoPresto (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674415#comment-15674415
 ] 

Andy LoPresto commented on NIFI-3051:
-

I am willing to look for {{org.apache.nifi.ldap.LdapProvider}} 
rather than a specific identifier, but much farther down that path would lead 
to anarchy -- people have to define the XML content to validly define an LDAP 
provider, not just arbitrary passwords. 

> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15673906#comment-15673906
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user YolandaMDavis commented on the issue:

https://github.com/apache/nifi/pull/1238
  
@alopresto just thought of a particular scenario.  If a user defines a 
provider with an identifier not equal to "ldap-provider" however has securable 
properties like those found in the ldap-provider template the tool currently 
does not catch that.  I'm wondering if it's possible to do something similar to 
what happens in nifi.properties where it searches for the value of password as 
a property and encrypts/decrypts that value?


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15673749#comment-15673749
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user YolandaMDavis commented on the issue:

https://github.com/apache/nifi/pull/1238
  
@alopresto actually correction, maven run of this test worked however 
individual execution of test in my IDE does not so this may not be an issue, 
probably a configuration problem on my end.


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15673684#comment-15673684
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user YolandaMDavis commented on the issue:

https://github.com/apache/nifi/pull/1238
  
@alopresto I rebased this with master and I have 7 tests are failing. I 
believe this may be due to recent changes in logging for toolkit, since all 
failed tests rely on assertions against events in the TestAppender class which 
doesn't get populated during the run.  Also I ran ConfigEncryptionToolTest in 
master (without this change) and the test is failing there as well.


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15673591#comment-15673591
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

Github user YolandaMDavis commented on the issue:

https://github.com/apache/nifi/pull/1238
  
@alopresto will review


> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672730#comment-15672730
 ] 

ASF GitHub Bot commented on NIFI-3051:
--

GitHub user alopresto opened a pull request:

https://github.com/apache/nifi/pull/1238

NIFI-3051 Fixed issue serializing commented or empty login-identity-p…

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

…roviders.xml.

Updated and added unit tests. (+1 squashed commit)
Squashed commits:
[b187202] NIFI-3051 - checked in test demonstrating failure to serialize 
commented ldap-provider section.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alopresto/nifi NIFI-3051

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1238


commit decd5e4d6000a881ee867d9020a3b9e57673a03b
Author: Andy LoPresto 
Date:   2016-11-17T03:38:59Z

NIFI-3051 Fixed issue serializing commented or empty 
login-identity-providers.xml.
Updated and added unit tests. (+1 squashed commit)
Squashed commits:
[b187202] NIFI-3051 - checked in test demonstrating failure to serialize 
commented ldap-provider section.




> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
>

[jira] [Commented] (NIFI-3051) Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File

2016-11-16 Thread Andy LoPresto (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672596#comment-15672596
 ] 

Andy LoPresto commented on NIFI-3051:
-

Thanks [~YolandaMDavis]. I believe this should be a quick fix and I will try to 
have it for tomorrow. 

> Encrypt Config - XML Parse Exception Occurs on Login Identity Providers File
> 
>
> Key: NIFI-3051
> URL: https://issues.apache.org/jira/browse/NIFI-3051
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.1.0
>Reporter: Yolanda M. Davis
>Assignee: Andy LoPresto
>
> I encountered an error when attempting to run encrypt config on a 
> login-identity-provider.xml file where the provider with "ldap-provider" 
> identity was commented out. The exception received is below:
> org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 1; Premature end 
> of file.
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:454)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:440)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:182)
>   at groovy.xml.XmlUtil.serialize(XmlUtil.java:151)
>   at groovy.xml.XmlUtil$serialize.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool.serializeLoginIdentityProvidersAndPreserveFormat(ConfigEncryptionTool.groovy:693)
>   at 
> org.apache.nifi.properties.ConfigEncryptionTool$serializeLoginIdentityProvidersAndPreserveFormat$0.call(Unknown
>  Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133)
> I've discussed this directly with [~alopresto] and he has agreed to 
> investigate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)