[jira] [Commented] (NIFI-3159) Long group name causes alignment issues in the access policy shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745316#comment-15745316
 ] 

ASF GitHub Bot commented on NIFI-3159:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1310


> Long group name causes alignment issues in the access policy shell
> --
>
> Key: NIFI-3159
> URL: https://issues.apache.org/jira/browse/NIFI-3159
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.2.0
>
> Attachments: Long group name in access policy shell.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3159) Long group name causes alignment issues in the access policy shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745318#comment-15745318
 ] 

ASF GitHub Bot commented on NIFI-3159:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1310
  
Thanks @scottyaslan! This has been merged to master.


> Long group name causes alignment issues in the access policy shell
> --
>
> Key: NIFI-3159
> URL: https://issues.apache.org/jira/browse/NIFI-3159
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.2.0
>
> Attachments: Long group name in access policy shell.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3159) Long group name causes alignment issues in the access policy shell

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745315#comment-15745315
 ] 

ASF subversion and git services commented on NIFI-3159:
---

Commit 868795cdaafbbba75432bcc2ec7e88110722db56 in nifi's branch 
refs/heads/master from [~scottyaslan]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=868795c ]

[NIFI-3159] Add ellipsis to long PG name in access policies shell. This closes 
#1310


> Long group name causes alignment issues in the access policy shell
> --
>
> Key: NIFI-3159
> URL: https://issues.apache.org/jira/browse/NIFI-3159
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.2.0
>
> Attachments: Long group name in access policy shell.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3159) Long group name causes alignment issues in the access policy shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743196#comment-15743196
 ] 

ASF GitHub Bot commented on NIFI-3159:
--

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1310#discussion_r92043862
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-policy-management.js
 ---
@@ -759,18 +759,23 @@ nf.PolicyManagement = (function () {
 });
 
 // build the mark up
-return $('Showing effective policy inherited from 
Process Group ').append($('').text(processGroupName).on('click', function () {
-// close the shell
-$('#shell-close-button').click();
-
-// load the correct group and unselect everything if 
necessary
-nf.CanvasUtils.enterGroup(processGroupId).done(function () 
{
-nf.CanvasUtils.getSelection().classed('selected', 
false);
-
-// inform Angular app that values have changed
-nf.ng.Bridge.digest();
-});
-})).append('.');
+return $('Showing 
effective policy inherited from Process Group ').append(
+$('')
--- End diff --

I'm pretty sure that the div's (`policy-message, new-policy-message, 
override-policy-message, and add-local-admin-message`) already align. The only 
issue was the content of `policy-message`. Specifically, the styles in the 
ellipsis class causes the surrounding text to shift downwards. Setting the link 
to `vertical-align: middle` should address this.


> Long group name causes alignment issues in the access policy shell
> --
>
> Key: NIFI-3159
> URL: https://issues.apache.org/jira/browse/NIFI-3159
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.2.0
>
> Attachments: Long group name in access policy shell.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3159) Long group name causes alignment issues in the access policy shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743155#comment-15743155
 ] 

ASF GitHub Bot commented on NIFI-3159:
--

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1310#discussion_r92041070
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-policy-management.js
 ---
@@ -759,18 +759,23 @@ nf.PolicyManagement = (function () {
 });
 
 // build the mark up
-return $('Showing effective policy inherited from 
Process Group ').append($('').text(processGroupName).on('click', function () {
-// close the shell
-$('#shell-close-button').click();
-
-// load the correct group and unselect everything if 
necessary
-nf.CanvasUtils.enterGroup(processGroupId).done(function () 
{
-nf.CanvasUtils.getSelection().classed('selected', 
false);
-
-// inform Angular app that values have changed
-nf.ng.Bridge.digest();
-});
-})).append('.');
+return $('Showing 
effective policy inherited from Process Group ').append(
+$('')
--- End diff --

Yea I see itI was trying to get it to line up with the "Override this 
policy" text and with the with this vertical-align it is off. What do you think 
about keeping the vertical-align and adding

#override-policy-message {
float: left;
position: relative;
top: 1px;
} 


> Long group name causes alignment issues in the access policy shell
> --
>
> Key: NIFI-3159
> URL: https://issues.apache.org/jira/browse/NIFI-3159
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.2.0
>
> Attachments: Long group name in access policy shell.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3159) Long group name causes alignment issues in the access policy shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742865#comment-15742865
 ] 

ASF GitHub Bot commented on NIFI-3159:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1310
  
Will review.


> Long group name causes alignment issues in the access policy shell
> --
>
> Key: NIFI-3159
> URL: https://issues.apache.org/jira/browse/NIFI-3159
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.2.0
>
> Attachments: Long group name in access policy shell.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3159) Long group name causes alignment issues in the access policy shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733370#comment-15733370
 ] 

ASF GitHub Bot commented on NIFI-3159:
--

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi/pull/1310

[NIFI-3159] Add ellipsis to long PG name in access policies shell

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi NIFI-3159

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1310.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1310


commit 468b32a5f38a9cb7cdcb05fd02fd25bfda3422a5
Author: Scott Aslan 
Date:   2016-12-08T16:20:51Z

[NIFI-3159] Add ellipsis to long PG name in access policies shell




> Long group name causes alignment issues in the access policy shell
> --
>
> Key: NIFI-3159
> URL: https://issues.apache.org/jira/browse/NIFI-3159
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.2.0
>
> Attachments: Long group name in access policy shell.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)