[jira] [Commented] (NIFI-3430) PutSQL Errors attempting to coerce date string to timestamp

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854422#comment-15854422
 ] 

ASF GitHub Bot commented on NIFI-3430:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1468


> PutSQL Errors attempting to coerce date string to timestamp
> ---
>
> Key: NIFI-3430
> URL: https://issues.apache.org/jira/browse/NIFI-3430
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nicholas Carenza
>Priority: Minor
>  Labels: convertjsontosql, putsql
>
> I am attempting to write a flat json object to my postgresql database using 
> ConvertJSONToSQL followed by PutSQL. My json has a string date field in ISO 
> 8601 format which postgres can accept as a timestamp. The column in the 
> database is of type 'timestamp without time zone'.
> org.apache.nifi.processor.exception.ProcessException: The value of the 
> sql.args.33.value is '2017-02-01T23:12:21+00:00', which cannot be converted 
> to a timestamp
> Is PutSQL trying to do some preprocessing here that it should just let the 
> database handle?
> select  cast('2017-02-01T23:12:21+00:00' as timestamp without time zone);
>   timestamp  
> -
>  2017-02-01 23:12:21
> (1 row)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3430) PutSQL Errors attempting to coerce date string to timestamp

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854421#comment-15854421
 ] 

ASF subversion and git services commented on NIFI-3430:
---

Commit 6466931c236aa29bfd95da63e0e6588fca420f97 in nifi's branch 
refs/heads/master from Nick Carenza
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=6466931 ]

NIFI-3430 - added support for specifying sql.arg.N.format for timestamp fields 
according to java.time.format.DateTimeFormatter

This closes #1468.


> PutSQL Errors attempting to coerce date string to timestamp
> ---
>
> Key: NIFI-3430
> URL: https://issues.apache.org/jira/browse/NIFI-3430
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Nicholas Carenza
>Priority: Minor
>  Labels: convertjsontosql, putsql
>
> I am attempting to write a flat json object to my postgresql database using 
> ConvertJSONToSQL followed by PutSQL. My json has a string date field in ISO 
> 8601 format which postgres can accept as a timestamp. The column in the 
> database is of type 'timestamp without time zone'.
> org.apache.nifi.processor.exception.ProcessException: The value of the 
> sql.args.33.value is '2017-02-01T23:12:21+00:00', which cannot be converted 
> to a timestamp
> Is PutSQL trying to do some preprocessing here that it should just let the 
> database handle?
> select  cast('2017-02-01T23:12:21+00:00' as timestamp without time zone);
>   timestamp  
> -
>  2017-02-01 23:12:21
> (1 row)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3430) PutSQL Errors attempting to coerce date string to timestamp

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854419#comment-15854419
 ] 

ASF GitHub Bot commented on NIFI-3430:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/1468
  
LGTM, I'll take care of merging @trixpan ;)
Thanks @nickcarenza 


> PutSQL Errors attempting to coerce date string to timestamp
> ---
>
> Key: NIFI-3430
> URL: https://issues.apache.org/jira/browse/NIFI-3430
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Nicholas Carenza
>Priority: Minor
>  Labels: convertjsontosql, putsql
>
> I am attempting to write a flat json object to my postgresql database using 
> ConvertJSONToSQL followed by PutSQL. My json has a string date field in ISO 
> 8601 format which postgres can accept as a timestamp. The column in the 
> database is of type 'timestamp without time zone'.
> org.apache.nifi.processor.exception.ProcessException: The value of the 
> sql.args.33.value is '2017-02-01T23:12:21+00:00', which cannot be converted 
> to a timestamp
> Is PutSQL trying to do some preprocessing here that it should just let the 
> database handle?
> select  cast('2017-02-01T23:12:21+00:00' as timestamp without time zone);
>   timestamp  
> -
>  2017-02-01 23:12:21
> (1 row)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3430) PutSQL Errors attempting to coerce date string to timestamp

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850582#comment-15850582
 ] 

ASF GitHub Bot commented on NIFI-3430:
--

Github user nickcarenza commented on the issue:

https://github.com/apache/nifi/pull/1468
  
@trixpan squashed and added details about the change in the processor 
description.


> PutSQL Errors attempting to coerce date string to timestamp
> ---
>
> Key: NIFI-3430
> URL: https://issues.apache.org/jira/browse/NIFI-3430
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Nicholas Carenza
>Priority: Minor
>  Labels: convertjsontosql, putsql
>
> I am attempting to write a flat json object to my postgresql database using 
> ConvertJSONToSQL followed by PutSQL. My json has a string date field in ISO 
> 8601 format which postgres can accept as a timestamp. The column in the 
> database is of type 'timestamp without time zone'.
> org.apache.nifi.processor.exception.ProcessException: The value of the 
> sql.args.33.value is '2017-02-01T23:12:21+00:00', which cannot be converted 
> to a timestamp
> Is PutSQL trying to do some preprocessing here that it should just let the 
> database handle?
> select  cast('2017-02-01T23:12:21+00:00' as timestamp without time zone);
>   timestamp  
> -
>  2017-02-01 23:12:21
> (1 row)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3430) PutSQL Errors attempting to coerce date string to timestamp

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850422#comment-15850422
 ] 

ASF GitHub Bot commented on NIFI-3430:
--

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1468
  
Nick, thank you for the contribution. would you mind squashing the commits?


> PutSQL Errors attempting to coerce date string to timestamp
> ---
>
> Key: NIFI-3430
> URL: https://issues.apache.org/jira/browse/NIFI-3430
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Nicholas Carenza
>Priority: Minor
>  Labels: convertjsontosql, putsql
>
> I am attempting to write a flat json object to my postgresql database using 
> ConvertJSONToSQL followed by PutSQL. My json has a string date field in ISO 
> 8601 format which postgres can accept as a timestamp. The column in the 
> database is of type 'timestamp without time zone'.
> org.apache.nifi.processor.exception.ProcessException: The value of the 
> sql.args.33.value is '2017-02-01T23:12:21+00:00', which cannot be converted 
> to a timestamp
> Is PutSQL trying to do some preprocessing here that it should just let the 
> database handle?
> select  cast('2017-02-01T23:12:21+00:00' as timestamp without time zone);
>   timestamp  
> -
>  2017-02-01 23:12:21
> (1 row)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3430) PutSQL Errors attempting to coerce date string to timestamp

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850314#comment-15850314
 ] 

ASF GitHub Bot commented on NIFI-3430:
--

GitHub user nickcarenza opened a pull request:

https://github.com/apache/nifi/pull/1468

NIFI-3430 adds support for date format property to parse incoming date 
strings

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nickcarenza/nifi NIFI-3430

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1468.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1468


commit 16fdb3b5753f5393ebe0d902269de5b1cf82fd03
Author: Nick Carenza 
Date:   2017-02-02T01:41:45Z

adds date_format property to parse incoming date strings

commit 65178852a81413a926bc7bc3d1f664c33de9fcfb
Author: Nick Carenza 
Date:   2017-02-02T18:49:50Z

refactored to use the existing valueFormat and 
java.time.format.DateTimeFormatter




> PutSQL Errors attempting to coerce date string to timestamp
> ---
>
> Key: NIFI-3430
> URL: https://issues.apache.org/jira/browse/NIFI-3430
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Nicholas Carenza
>  Labels: convertjsontosql, putsql
>
> I am attempting to write a flat json object to my postgresql database using 
> ConvertJSONToSQL followed by PutSQL. My json has a string date field in ISO 
> 8601 format which postgres can accept as a timestamp. The column in the 
> database is of type 'timestamp without time zone'.
> org.apache.nifi.processor.exception.ProcessException: The value of the 
> sql.args.33.value is '2017-02-01T23:12:21+00:00', which cannot be converted 
> to a timestamp
> Is PutSQL trying to do some preprocessing here that it should just let the 
> database handle?
> select  cast('2017-02-01T23:12:21+00:00' as timestamp without time zone);
>   timestamp  
> -
>  2017-02-01 23:12:21
> (1 row)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3430) PutSQL Errors attempting to coerce date string to timestamp

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850309#comment-15850309
 ] 

ASF GitHub Bot commented on NIFI-3430:
--

Github user nickcarenza closed the pull request at:

https://github.com/apache/nifi/pull/1463


> PutSQL Errors attempting to coerce date string to timestamp
> ---
>
> Key: NIFI-3430
> URL: https://issues.apache.org/jira/browse/NIFI-3430
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Nicholas Carenza
>  Labels: convertjsontosql, putsql
>
> I am attempting to write a flat json object to my postgresql database using 
> ConvertJSONToSQL followed by PutSQL. My json has a string date field in ISO 
> 8601 format which postgres can accept as a timestamp. The column in the 
> database is of type 'timestamp without time zone'.
> org.apache.nifi.processor.exception.ProcessException: The value of the 
> sql.args.33.value is '2017-02-01T23:12:21+00:00', which cannot be converted 
> to a timestamp
> Is PutSQL trying to do some preprocessing here that it should just let the 
> database handle?
> select  cast('2017-02-01T23:12:21+00:00' as timestamp without time zone);
>   timestamp  
> -
>  2017-02-01 23:12:21
> (1 row)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3430) PutSQL Errors attempting to coerce date string to timestamp

[Nicholas Carenza (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849258#comment-15849258
 ] 

Nicholas Carenza commented on NIFI-3430:


https://github.com/apache/nifi/pull/1463

> PutSQL Errors attempting to coerce date string to timestamp
> ---
>
> Key: NIFI-3430
> URL: https://issues.apache.org/jira/browse/NIFI-3430
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Nicholas Carenza
>  Labels: convertjsontosql, putsql
>
> I am attempting to write a flat json object to my postgresql database using 
> ConvertJSONToSQL followed by PutSQL. My json has a string date field in ISO 
> 8601 format which postgres can accept as a timestamp. The column in the 
> database is of type 'timestamp without time zone'.
> org.apache.nifi.processor.exception.ProcessException: The value of the 
> sql.args.33.value is '2017-02-01T23:12:21+00:00', which cannot be converted 
> to a timestamp
> Is PutSQL trying to do some preprocessing here that it should just let the 
> database handle?
> select  cast('2017-02-01T23:12:21+00:00' as timestamp without time zone);
>   timestamp  
> -
>  2017-02-01 23:12:21
> (1 row)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3430) PutSQL Errors attempting to coerce date string to timestamp

[Nicholas Carenza (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849233#comment-15849233
 ] 

Nicholas Carenza commented on NIFI-3430:


Apprently it only supports a single string date format hardcoded into the 
processor:
`SimpleDateFormat dateFormat = new SimpleDateFormat("-MM-dd HH:mm:ss.SSS");`

> PutSQL Errors attempting to coerce date string to timestamp
> ---
>
> Key: NIFI-3430
> URL: https://issues.apache.org/jira/browse/NIFI-3430
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Nicholas Carenza
>  Labels: convertjsontosql, putsql
>
> I am attempting to write a flat json object to my postgresql database using 
> ConvertJSONToSQL followed by PutSQL. My json has a string date field in ISO 
> 8601 format which postgres can accept as a timestamp. The column in the 
> database is of type 'timestamp without time zone'.
> org.apache.nifi.processor.exception.ProcessException: The value of the 
> sql.args.33.value is '2017-02-01T23:12:21+00:00', which cannot be converted 
> to a timestamp
> Is PutSQL trying to do some preprocessing here that it should just let the 
> database handle?
> select  cast('2017-02-01T23:12:21+00:00' as timestamp without time zone);
>   timestamp  
> -
>  2017-02-01 23:12:21
> (1 row)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)