[jira] [Commented] (NIFI-3939) Fix entity type mismatches in web API resource response types
[
https://issues.apache.org/jira/browse/NIFI-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080843#comment-16080843
]
ASF GitHub Bot commented on NIFI-3939:
--
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1999
Thanks @m-hogue! This has been merged to master.
> Fix entity type mismatches in web API resource response types
> --
>
> Key: NIFI-3939
> URL: https://issues.apache.org/jira/browse/NIFI-3939
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Joe Skora
>Assignee: Michael Hogue
>
> In {{ProcessGroupResource.java}} annotations on the
> {{/process-groups/\{id}/getProcessGroups}} endpoint incorrectly identifies
> the response as a {{ProcessorsEntity}} when it should be a
> {{ProcessGroupsEntity}}. Similar mismatches may exist in
> {{FlowFileQueueResource}}, {{FlowResource}}, and possibly other classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (NIFI-3939) Fix entity type mismatches in web API resource response types
[
https://issues.apache.org/jira/browse/NIFI-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080844#comment-16080844
]
ASF GitHub Bot commented on NIFI-3939:
--
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1999
> Fix entity type mismatches in web API resource response types
> --
>
> Key: NIFI-3939
> URL: https://issues.apache.org/jira/browse/NIFI-3939
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Joe Skora
>Assignee: Michael Hogue
>
> In {{ProcessGroupResource.java}} annotations on the
> {{/process-groups/\{id}/getProcessGroups}} endpoint incorrectly identifies
> the response as a {{ProcessorsEntity}} when it should be a
> {{ProcessGroupsEntity}}. Similar mismatches may exist in
> {{FlowFileQueueResource}}, {{FlowResource}}, and possibly other classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (NIFI-3939) Fix entity type mismatches in web API resource response types
[
https://issues.apache.org/jira/browse/NIFI-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080841#comment-16080841
]
ASF subversion and git services commented on NIFI-3939:
---
Commit 78fbb8f2ee70d264787856e4a6337217bcfeba79 in nifi's branch
refs/heads/master from m-hogue
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=78fbb8f ]
NIFI-3939: Reviewed and corrected all incorrect nifi-web-api resource response
types. This closes #1999
> Fix entity type mismatches in web API resource response types
> --
>
> Key: NIFI-3939
> URL: https://issues.apache.org/jira/browse/NIFI-3939
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Joe Skora
>Assignee: Michael Hogue
>
> In {{ProcessGroupResource.java}} annotations on the
> {{/process-groups/\{id}/getProcessGroups}} endpoint incorrectly identifies
> the response as a {{ProcessorsEntity}} when it should be a
> {{ProcessGroupsEntity}}. Similar mismatches may exist in
> {{FlowFileQueueResource}}, {{FlowResource}}, and possibly other classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (NIFI-3939) Fix entity type mismatches in web API resource response types
[
https://issues.apache.org/jira/browse/NIFI-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080838#comment-16080838
]
ASF GitHub Bot commented on NIFI-3939:
--
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1999
Will review...
> Fix entity type mismatches in web API resource response types
> --
>
> Key: NIFI-3939
> URL: https://issues.apache.org/jira/browse/NIFI-3939
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Joe Skora
>Assignee: Michael Hogue
>
> In {{ProcessGroupResource.java}} annotations on the
> {{/process-groups/\{id}/getProcessGroups}} endpoint incorrectly identifies
> the response as a {{ProcessorsEntity}} when it should be a
> {{ProcessGroupsEntity}}. Similar mismatches may exist in
> {{FlowFileQueueResource}}, {{FlowResource}}, and possibly other classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (NIFI-3939) Fix entity type mismatches in web API resource response types
[
https://issues.apache.org/jira/browse/NIFI-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080523#comment-16080523
]
ASF GitHub Bot commented on NIFI-3939:
--
GitHub user m-hogue opened a pull request:
https://github.com/apache/nifi/pull/1999
NIFI-3939: Reviewed and corrected all incorrect nifi-web-api resource…
… response types
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/m-hogue/nifi NIFI-3939
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1999.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1999
> Fix entity type mismatches in web API resource response types
> --
>
> Key: NIFI-3939
> URL: https://issues.apache.org/jira/browse/NIFI-3939
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Joe Skora
>Assignee: Michael Hogue
>
> In {{ProcessGroupResource.java}} annotations on the
> {{/process-groups/\{id}/getProcessGroups}} endpoint incorrectly identifies
> the response as a {{ProcessorsEntity}} when it should be a
> {{ProcessGroupsEntity}}. Similar mismatches may exist in
> {{FlowFileQueueResource}}, {{FlowResource}}, and possibly other classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
