[jira] [Commented] (NIFI-4172) Typo in nifi-web-api Entity class name

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1433#comment-1433
 ] 

ASF subversion and git services commented on NIFI-4172:
---

Commit 8bfb6be5baf8361dbfd88688e9ba13af70d530b0 in nifi's branch 
refs/heads/main from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8bfb6be5ba ]

NIFI-4172: Renamed ClusteSummaryEntity to ClusterSummaryEntity

This closes #7900

Signed-off-by: David Handermann 


> Typo in nifi-web-api Entity class name
> --
>
> Key: NIFI-4172
> URL: https://issues.apache.org/jira/browse/NIFI-4172
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Michael Hogue
>Assignee: Mark Payne
>Priority: Trivial
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There's an Entity in {{nifi-web-api}} named {{ClusteSummaryEntity}}. This 
> should be {{ClusterSummaryEntity}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (NIFI-4172) Typo in nifi-web-api Entity class name

[Matt Gilman (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080652#comment-16080652
 ] 

Matt Gilman commented on NIFI-4172:
---

Updating the fix version to 2.0.0 since the change will break backward 
compatibility. 

> Typo in nifi-web-api Entity class name
> --
>
> Key: NIFI-4172
> URL: https://issues.apache.org/jira/browse/NIFI-4172
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Michael Hogue
>Assignee: Michael Hogue
>Priority: Trivial
> Fix For: 2.0.0
>
>
> There's an Entity in {{nifi-web-api}} named {{ClusteSummaryEntity}}. This 
> should be {{ClusterSummaryEntity}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4172) Typo in nifi-web-api Entity class name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080663#comment-16080663
 ] 

ASF GitHub Bot commented on NIFI-4172:
--

Github user m-hogue closed the pull request at:

https://github.com/apache/nifi/pull/2000


> Typo in nifi-web-api Entity class name
> --
>
> Key: NIFI-4172
> URL: https://issues.apache.org/jira/browse/NIFI-4172
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Michael Hogue
>Assignee: Michael Hogue
>Priority: Trivial
> Fix For: 2.0.0
>
>
> There's an Entity in {{nifi-web-api}} named {{ClusteSummaryEntity}}. This 
> should be {{ClusterSummaryEntity}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4172) Typo in nifi-web-api Entity class name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080662#comment-16080662
 ] 

ASF GitHub Bot commented on NIFI-4172:
--

Github user m-hogue commented on the issue:

https://github.com/apache/nifi/pull/2000
  
Closing, to be merged for 2.0.0.


> Typo in nifi-web-api Entity class name
> --
>
> Key: NIFI-4172
> URL: https://issues.apache.org/jira/browse/NIFI-4172
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Michael Hogue
>Assignee: Michael Hogue
>Priority: Trivial
> Fix For: 2.0.0
>
>
> There's an Entity in {{nifi-web-api}} named {{ClusteSummaryEntity}}. This 
> should be {{ClusterSummaryEntity}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4172) Typo in nifi-web-api Entity class name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080655#comment-16080655
 ] 

ASF GitHub Bot commented on NIFI-4172:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2000
  
I've updated the fix version on the JIRA so we'll catch it for 2.0.0. 
Unfortunately, I cannot close the PR without a commit. Only the person that 
created the PR can do so. Do you mind closing? Thanks!


> Typo in nifi-web-api Entity class name
> --
>
> Key: NIFI-4172
> URL: https://issues.apache.org/jira/browse/NIFI-4172
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Michael Hogue
>Assignee: Michael Hogue
>Priority: Trivial
> Fix For: 2.0.0
>
>
> There's an Entity in {{nifi-web-api}} named {{ClusteSummaryEntity}}. This 
> should be {{ClusterSummaryEntity}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4172) Typo in nifi-web-api Entity class name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080626#comment-16080626
 ] 

ASF GitHub Bot commented on NIFI-4172:
--

Github user m-hogue commented on the issue:

https://github.com/apache/nifi/pull/2000
  
Ah, okay. I'd thought the potential for this to be a breaking API change 
prior to making the fix, but I was thinking from a REST API perspective since 
the response type isn't part of a json response.

Feel free to close this. It's fairly trivial, so it's easy to do again 
prior to a major release. Thanks!


> Typo in nifi-web-api Entity class name
> --
>
> Key: NIFI-4172
> URL: https://issues.apache.org/jira/browse/NIFI-4172
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Michael Hogue
>Assignee: Michael Hogue
>Priority: Trivial
>
> There's an Entity in {{nifi-web-api}} named {{ClusteSummaryEntity}}. This 
> should be {{ClusterSummaryEntity}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4172) Typo in nifi-web-api Entity class name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080618#comment-16080618
 ] 

ASF GitHub Bot commented on NIFI-4172:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2000
  
Thanks for the PR @m-hogue. I almost made this fix myself awhile back and 
held off. Technically, this class is part of a domain model for the REST API. 
Folks should be able to use this model in conjunction with frameworks like 
Jersey or RestEasy to interact with the REST API. Because of this, we treat 
this as another public API and we don't introduce breaking changes outside of 
major releases. 

Fortunately, the typo is not visible to folks consuming the REST API 
without our DTO domain model (through curl for instance). 


> Typo in nifi-web-api Entity class name
> --
>
> Key: NIFI-4172
> URL: https://issues.apache.org/jira/browse/NIFI-4172
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Michael Hogue
>Assignee: Michael Hogue
>Priority: Trivial
>
> There's an Entity in {{nifi-web-api}} named {{ClusteSummaryEntity}}. This 
> should be {{ClusterSummaryEntity}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4172) Typo in nifi-web-api Entity class name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080544#comment-16080544
 ] 

ASF GitHub Bot commented on NIFI-4172:
--

GitHub user m-hogue opened a pull request:

https://github.com/apache/nifi/pull/2000

NIFI-4172: renamed ClusteSummaryEntity to ClusterSummaryEntity

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/m-hogue/nifi NIFI-4172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2000.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2000


commit e475e7175923bb03cde40076ce64a2648e5b62d6
Author: m-hogue 
Date:   2017-07-10T15:53:22Z

NIFI-4172: renamed ClusteSummaryEntity to ClusterSummaryEntity




> Typo in nifi-web-api Entity class name
> --
>
> Key: NIFI-4172
> URL: https://issues.apache.org/jira/browse/NIFI-4172
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Michael Hogue
>Assignee: Michael Hogue
>Priority: Trivial
>
> There's an Entity in {{nifi-web-api}} named {{ClusteSummaryEntity}}. This 
> should be {{ClusterSummaryEntity}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)