[jira] [Commented] (NIFI-4304) Create build property for HWX schema registry client version

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131216#comment-16131216
 ] 

ASF subversion and git services commented on NIFI-4304:
---

Commit 60d4672195b89cb12e1f75f0a537c9adbab654bd in nifi's branch 
refs/heads/master from [~bbende]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=60d4672 ]

NIFI-4304 Extracting HWX Schema Registry client version to a property and 
bumping to latest 0.3.0 release

Signed-off-by: Matthew Burgess 

This closes #2096


> Create build property for HWX schema registry client version
> 
>
> Key: NIFI-4304
> URL: https://issues.apache.org/jira/browse/NIFI-4304
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
>
> Currently the version of the HWX schema registry client is defined directly 
> in the pom of the service module:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L61
> We should define a property in the root pom for the version and reference it 
> there, like we do for many other versions, this would let someone easily 
> override it at build time. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4304) Create build property for HWX schema registry client version

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131217#comment-16131217
 ] 

ASF GitHub Bot commented on NIFI-4304:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2096


> Create build property for HWX schema registry client version
> 
>
> Key: NIFI-4304
> URL: https://issues.apache.org/jira/browse/NIFI-4304
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
>
> Currently the version of the HWX schema registry client is defined directly 
> in the pom of the service module:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L61
> We should define a property in the root pom for the version and reference it 
> there, like we do for many other versions, this would let someone easily 
> override it at build time. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4304) Create build property for HWX schema registry client version

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131215#comment-16131215
 ] 

ASF GitHub Bot commented on NIFI-4304:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2096
  
+1 LGTM, ran tests and verified version upgrade, thanks! Merging to master


> Create build property for HWX schema registry client version
> 
>
> Key: NIFI-4304
> URL: https://issues.apache.org/jira/browse/NIFI-4304
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
>
> Currently the version of the HWX schema registry client is defined directly 
> in the pom of the service module:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L61
> We should define a property in the root pom for the version and reference it 
> there, like we do for many other versions, this would let someone easily 
> override it at build time. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4304) Create build property for HWX schema registry client version

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130843#comment-16130843
 ] 

ASF GitHub Bot commented on NIFI-4304:
--

GitHub user bbende opened a pull request:

https://github.com/apache/nifi/pull/2096

NIFI-4304 Extracting HWX Schema Registry client version to a property…

… and bumping to latest 0.3.0 release

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbende/nifi NIFI-4304

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2096.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2096


commit 147b5280fbd7f70886eecdd051d014d2099a7760
Author: Bryan Bende 
Date:   2017-08-17T17:08:33Z

NIFI-4304 Extracting HWX Schema Registry client version to a property and 
bumping to latest 0.3.0 release




> Create build property for HWX schema registry client version
> 
>
> Key: NIFI-4304
> URL: https://issues.apache.org/jira/browse/NIFI-4304
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
>
> Currently the version of the HWX schema registry client is defined directly 
> in the pom of the service module:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L61
> We should define a property in the root pom for the version and reference it 
> there, like we do for many other versions, this would let someone easily 
> override it at build time. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)